Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issue 24254005: Scripts should not care about closed tree when committing. (Closed)

Created:
7 years, 3 months ago by Yang
Modified:
7 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Scripts should not care about closed tree when committing. I just got bitten by this when merging to branch. R=jkummerow@chromium.org, machenbach@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16921

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M PRESUBMIT.py View 1 2 chunks +15 lines, -3 lines 0 comments Download
M tools/merge-to-branch.sh View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/push-to-trunk.sh View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Yang
7 years, 3 months ago (2013-09-23 13:17:42 UTC) #1
Michael Achenbach
On 2013/09/23 13:17:42, Yang wrote: LGTM
7 years, 3 months ago (2013-09-23 13:55:29 UTC) #2
Jakob Kummerow
As discussed offline, I think a better approach is to teach the presubmit check to ...
7 years, 3 months ago (2013-09-23 14:06:08 UTC) #3
Yang
On 2013/09/23 14:06:08, Jakob wrote: > As discussed offline, I think a better approach is ...
7 years, 3 months ago (2013-09-23 15:29:47 UTC) #4
Jakob Kummerow
LGTM. Thanks for going the extra mile!
7 years, 3 months ago (2013-09-23 16:05:49 UTC) #5
Yang
7 years, 3 months ago (2013-09-24 13:36:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r16921 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698