Issue 24254004: Make Dart_IdentityEqual live up to its sepc and not leak boxing implementation detail. (Reland r275…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24254004: Make Dart_IdentityEqual live up to its sepc and not leak boxing implementation detail. (Reland r275… (Closed)

Created:
7 years, 3 months ago by rmacnak

Modified:
7 years, 2 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Make Dart_IdentityEqual live up to its sepc and not leak boxing implementation detail. (Reland r27542.) R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=27774

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -18 lines)			Patch
M	runtime/include/dart_api.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/lib/identical.cc	View		1 chunk	+1 line, -15 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1	1 chunk	+12 lines, -2 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/object.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

rmacnak

7 years, 2 months ago (2013-09-23 16:23:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r27774 (presubmit successful).