Android / Telemetry: final cleanup on perf_tests_helper.

Android / Telemetry: final cleanup on perf_tests_helper.

This module has moved to build/util/lib/common.
Fix up remaining references and remove the old file.
Also, bring up a tiny change that went on the old module (units for histogram).

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225532

[bulach, 2013-09-19 16:18:03]

frankf for build/
dtu / rschoen for telemetry/

the downstream patch hasn't landed yet, so this have to wait to land..but as far
as codereview goes, ptal :)

[dtu, 2013-09-20 02:02:28]

telemetry lgtm

[frankf, 2013-09-20 02:07:39]

lgtm after fix. Thanks.

https://chromiumcodereview.appspot.com/24253006/diff/1/build/android/pylib/in...
File build/android/pylib/instrumentation/test_runner.py (right):

https://chromiumcodereview.appspot.com/24253006/diff/1/build/android/pylib/in...
build/android/pylib/instrumentation/test_runner.py:13:
sys.path.append(os.path.join(sys.path[0],
import sys

https://chromiumcodereview.appspot.com/24253006/diff/1/build/util/lib/common/...
File build/util/lib/common/perf_tests_results_helper.py (right):

https://chromiumcodereview.appspot.com/24253006/diff/1/build/util/lib/common/...
build/util/lib/common/perf_tests_results_helper.py:142: units)
why didn't this include units before?

[bulach, 2013-09-20 08:23:45]

+ilevy for build/android/buildbot/OWNERS

https://chromiumcodereview.appspot.com/24253006/diff/1/build/android/pylib/in...
File build/android/pylib/instrumentation/test_runner.py (right):

https://chromiumcodereview.appspot.com/24253006/diff/1/build/android/pylib/in...
build/android/pylib/instrumentation/test_runner.py:13:
sys.path.append(os.path.join(sys.path[0],
On 2013/09/20 02:07:39, frankf wrote:
> import sys

Done.

https://chromiumcodereview.appspot.com/24253006/diff/1/build/util/lib/common/...
File build/util/lib/common/perf_tests_results_helper.py (right):

https://chromiumcodereview.appspot.com/24253006/diff/1/build/util/lib/common/...
build/util/lib/common/perf_tests_results_helper.py:142: units)
On 2013/09/20 02:07:39, frankf wrote:
> why didn't this include units before?

bad timing :)
ryan splitted this file (build/util/lib/common) from android
(build/android/pylib), but there was one change in there
https://chromiumcodereview.appspot.com/23470006 after this split and before I
was able to delete the android version :)

so this patch picks up that change and removes the android version once and for
all..

[bulach, 2013-09-23 13:46:35]

ping?

[bulach, 2013-09-25 09:09:40]

+navabi for build/android/buildbot

[navabi, 2013-09-25 18:01:57]

On 2013/09/25 09:09:40, bulach wrote:
> +navabi for build/android/buildbot

buildbot lgtm.

I did a git grep for perf_tests_helper. There are references that are not
changed in this CL in the following telemetry files:
tools/telemetry/telemetry/page/buildbot_page_measurement_results.py
tools/telemetry/telemetry/page/buildbot_page_measurement_results_unittest.py
tools/telemetry/telemetry/page/page_measurement_results_unittest.py
tools/telemetry/telemetry/page/page_measurement_value.py
Are those all ok?

[bulach, 2013-09-26 08:13:07]

thanks armand!

yes, all the telemetry files importing "perf_tests_helper" are actually
referencing "tools/telemetry/telemetry/page/perf_tests_helper.py", which is
being adjusted in this patch :)

there are no more references to "build/android/pylib/perf_tests_helper.py"

CQing..

[commit-bot: I haz the power, 2013-09-26 08:17:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/24253006/17001

[commit-bot: I haz the power, 2013-09-26 08:31:59]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[bulach, 2013-09-26 14:08:53]

armand: needs an LGTM from your @chromium :)
(I also fixed a minor pylint issue in the latest patchset)

[navabi1, 2013-09-26 16:47:19]

On 2013/09/26 14:08:53, bulach wrote:
> armand: needs an LGTM from your @chromium :)
> (I also fixed a minor pylint issue in the latest patchset)

Thanks Marcus. lgtm.

[commit-bot: I haz the power, 2013-09-26 17:01:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/24253006/42001

[commit-bot: I haz the power, 2013-09-26 19:19:26]

Change committed as 225532