Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2425243003: PPC/s390: [ic] Unify CallIC feedback collection and handling. (Closed)

Created:
4 years, 2 months ago by JaideepBajwa
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [ic] Unify CallIC feedback collection and handling. Port 308788b3069703117a9004e64c06c26137c84263 Original commit message: Consistently collect CallIC feedback in fullcodegen and Ignition, even for possibly direct eval calls, that were treated specially so far, for no apparent reason. With the upcoming SharedFunctionInfo based CallIC feedback, we might be able to even inline certain direct eval calls, if they manage to hit the eval cache. More importantly, this patch simplifies the collection and dealing with CallIC feedback (and as a side effect fixes an inconsistency with feedback for super constructor calls). R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/78085e4d7f10a251c7f19daea70784895a1eb261 Cr-Commit-Position: refs/heads/master@{#40412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 2 months ago (2016-10-18 22:31:25 UTC) #1
john.yan
lgtm
4 years, 2 months ago (2016-10-18 22:32:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425243003/1
4 years, 2 months ago (2016-10-18 22:33:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 22:59:04 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:05:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78085e4d7f10a251c7f19daea70784895a1eb261
Cr-Commit-Position: refs/heads/master@{#40412}

Powered by Google App Engine
This is Rietveld 408576698