Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2425193002: libyuv: Make Windows trybots also build with VS2013. (Closed)

Created:
4 years, 2 months ago by kjellander_chromium
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

libyuv: Make Windows trybots also build with VS2013. The commit bots are configured to specify Visual Studio 2013 while the trybots aren't (which I guess means they're defaulting to Visual Studio 2015 as part of the Chromium build toolchain). BUG=chromium:652188 TBR=fbarchard@chromium.org, ehmaldonado@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/build/+/0aca4a6174120097e93b1f220a8c0c959862a084

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M scripts/slave/recipe_modules/libyuv/builders.py View 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win.json View 2 chunks +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_rel.json View 2 chunks +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_rel.json View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
kjellander_chromium
Frank: should libyuv build fine with VS2015, should we change the bots or add additional ...
4 years, 2 months ago (2016-10-18 11:19:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425193002/1
4 years, 2 months ago (2016-10-18 11:19:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/0aca4a6174120097e93b1f220a8c0c959862a084
4 years, 2 months ago (2016-10-18 11:28:46 UTC) #7
fbarchard1
4 years, 1 month ago (2016-10-25 18:07:52 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698