Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2425183002: X87: [builtins] Remove the unused AllocationSite slot from ConstructFrame. (Closed)

Created:
4 years, 2 months ago by zhengxing.li
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Remove the unused AllocationSite slot from ConstructFrame. port 77419488a971aa9be4da1f167cd5afe0c7537d01 (r40377) original commit message: This slot is completely unused and always undefined anyways, so there's no need to maintain the slot during object construction. BUG= Committed: https://crrev.com/62649b82406b39b8d8ebec5e9142ba077dc9389e Cr-Commit-Position: refs/heads/master@{#40389}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M src/builtins/x87/builtins-x87.cc View 4 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 2 months ago (2016-10-18 07:43:54 UTC) #2
Weiliang
lgtm
4 years, 2 months ago (2016-10-18 07:47:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425183002/1
4 years, 2 months ago (2016-10-18 08:24:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 08:48:08 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 08:48:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62649b82406b39b8d8ebec5e9142ba077dc9389e
Cr-Commit-Position: refs/heads/master@{#40389}

Powered by Google App Engine
This is Rietveld 408576698