Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 242513009: Removing empty function definitions and WebAXObject interfaces (Closed)

Created:
6 years, 8 months ago by suyash
Modified:
6 years, 8 months ago
Reviewers:
dmazzoni, dglazkov
CC:
blink-reviews, jamesr, dglazkov+blink, dmazzoni, aboxhall, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Removing empty function definitions and WebAXObject interfaces There were *FIXME* in thirdparty/Webkit//Source/core/accessibility/AXObjectCache.cpp rregarding no necessity of the functions startCachingComputedObjectAttributesUntilTreeMutates() and stopCachingComputedObjectAttributes() and concerned WebAXObject interfaces. Already uploaded the patch with Chromium side changes. (https://codereview.chromium.org/245053004/) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172319

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M Source/core/accessibility/AXObjectCache.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/accessibility/AXObjectCache.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/web/WebAXObject.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M public/web/WebAXObject.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
suyash
Kindly review the patch.Thanks!
6 years, 8 months ago (2014-04-21 12:46:17 UTC) #1
dmazzoni
lgtm +dglazkov for public/web (Please don't cq until Chromium change lands)
6 years, 8 months ago (2014-04-21 14:49:41 UTC) #2
suyash
Thanks for the review. Will make sure the chromium patch lands first
6 years, 8 months ago (2014-04-22 07:57:57 UTC) #3
suyash
The CQ bit was checked by suyash.s@samsung.com
6 years, 8 months ago (2014-04-22 08:54:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/242513009/1
6 years, 8 months ago (2014-04-22 08:54:44 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 09:02:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 8 months ago (2014-04-22 09:02:12 UTC) #7
suyash
On 2014/04/22 09:02:12, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 8 months ago (2014-04-22 09:12:10 UTC) #8
dglazkov
lgtm
6 years, 8 months ago (2014-04-22 15:25:40 UTC) #9
suyash
The CQ bit was checked by suyash.s@samsung.com
6 years, 8 months ago (2014-04-23 04:56:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/242513009/1
6 years, 8 months ago (2014-04-23 04:56:22 UTC) #11
suyash
On 2014/04/23 04:56:22, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 8 months ago (2014-04-23 05:14:27 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 06:06:51 UTC) #13
Message was sent while issue was closed.
Change committed as 172319

Powered by Google App Engine
This is Rietveld 408576698