Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1279)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

Issue 24251012: Improve the memory consumption and performance of our string buffer implementation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update comment. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart b/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
index ba51d89b47d7c917b1913646eacefaa8768d3342..f63e6eca25bfd0b49172bd1e84fac543b85aa7a8 100644
--- a/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
@@ -4059,7 +4059,7 @@ if (typeof $printHelperName === "function") {
mainBuffer.add('})()$n');
}
compiler.assembledCode = mainBuffer.getText();
- outputSourceMap(mainBuffer, compiler.assembledCode, '');
+ outputSourceMap(compiler.assembledCode, '');
emitDeferredCode();
@@ -4163,7 +4163,7 @@ if (typeof $printHelperName === "function") {
compiler.outputProvider('part', 'js')
..add(code)
..close();
- outputSourceMap(buffer, compiler.assembledCode, 'part');
+ outputSourceMap(compiler.assembledCode, 'part');
}
String buildGeneratedBy() {
@@ -4179,7 +4179,7 @@ if (typeof $printHelperName === "function") {
return sourceMapBuilder.build(compiledFile);
}
- void outputSourceMap(CodeBuffer buffer, String code, String name) {
+ void outputSourceMap(String code, String name) {
if (!generateSourceMap) return;
SourceFile compiledFile = new SourceFile(null, compiler.assembledCode);
String sourceMap = buildSourceMap(mainBuffer, compiledFile);

Powered by Google App Engine
This is Rietveld 408576698