Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/net/http/http_security_headers_unittest.cc

Issue 24251011: Revert 224269 "Don't persist HPKP if PrivacyMode is enabled." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/chrome_frame/test/net/fake_external_tab.cc ('k') | trunk/src/net/http/transport_security_state.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/net/http/http_security_headers_unittest.cc
===================================================================
--- trunk/src/net/http/http_security_headers_unittest.cc (revision 224274)
+++ trunk/src/net/http/http_security_headers_unittest.cc (working copy)
@@ -440,7 +440,7 @@
// docs.google.com has preloaded pins.
std::string domain = "docs.google.com";
- EXPECT_TRUE(state.GetDomainState(domain, true, true, &domain_state));
+ EXPECT_TRUE(state.GetDomainState(domain, true, &domain_state));
EXPECT_GT(domain_state.static_spki_hashes.size(), 1UL);
HashValueVector saved_hashes = domain_state.static_spki_hashes;
@@ -487,7 +487,7 @@
EXPECT_NE(dynamic_domain_state.dynamic_spki_hashes.end(), hash);
// Expect the overall state to reflect the header, too.
- EXPECT_TRUE(state.GetDomainState(domain, true, true, &domain_state));
+ EXPECT_TRUE(state.GetDomainState(domain, true, &domain_state));
EXPECT_EQ(2UL, domain_state.dynamic_spki_hashes.size());
hash = std::find_if(domain_state.dynamic_spki_hashes.begin(),
« no previous file with comments | « trunk/src/chrome_frame/test/net/fake_external_tab.cc ('k') | trunk/src/net/http/transport_security_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698