Issue 2425043002: GN: Fix Debug flags. Fix Windows build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2425043002: GN: Fix Debug flags. Fix Windows build. (Closed)

Created:
4 years, 2 months ago by zra

Modified:
4 years, 2 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -5 lines)			Patch
M	build/config/compiler/BUILD.gn	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/platform/globals.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/kernel_binary.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

zra

4 years, 2 months ago (2016-10-17 19:58:30 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
71a84cfed6ca5f92c5ceddaebe01400b98584142 (presubmit successful).