Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 2425013002: S390: Change printf format specifier in mark-compact.cc (Closed)

Created:
4 years, 2 months ago by yangtian.zi
Modified:
4 years, 2 months ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, JoranSiu, john.yan, JaideepBajwa, michael_dawson, MTBrandyberry
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Change printf format specifier in mark-compact.cc fragmentation_limit_kb has type of size_t, using PRIuS instead of V8PRIdPTR. R=mlippautz@chromium.org, ulan@chromium.org BUG= Committed: https://crrev.com/e75c5a64277d5edfdfa8905b6f8b37ef1e1aca13 Cr-Commit-Position: refs/heads/master@{#40371}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap/mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
yangtian.zi
ptal
4 years, 2 months ago (2016-10-17 19:05:14 UTC) #1
Michael Lippautz
lgtm
4 years, 2 months ago (2016-10-17 19:22:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425013002/1
4 years, 2 months ago (2016-10-17 19:24:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 19:50:36 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 19:50:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e75c5a64277d5edfdfa8905b6f8b37ef1e1aca13
Cr-Commit-Position: refs/heads/master@{#40371}

Powered by Google App Engine
This is Rietveld 408576698