Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Issue 2425003002: FPDFPage_TransformAnnots(): don't re-insert unowned object on top of itself (Closed)

Created:
4 years, 2 months ago by Tom Sepez
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

FPDFPage_TransformAnnots(): don't re-insert unowned object on top of itself Underlying cause of the bug, unmasked when CPDF_Dictionary lost a redundancy check. BUG=656162 Committed: https://pdfium.googlesource.com/pdfium/+/8021a646f18d76518be32c36907a04f213a0e21c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M fpdfsdk/fpdfeditpage.cpp View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Tom Sepez
Lei, for review.
4 years, 2 months ago (2016-10-17 19:04:06 UTC) #3
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-17 22:44:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425003002/1
4 years, 2 months ago (2016-10-17 23:05:07 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 23:13:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/8021a646f18d76518be32c36907a04f213a0...

Powered by Google App Engine
This is Rietveld 408576698