Only match host port pair when determining if a proxy is a data reduction proxy

components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
index 78f2c5982d9d1639c1d29c82027e00352c30fa27..67d424f5e64439b15b209e1b8efcae3aeea90c42 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
@@ -353,8 +353,14 @@ bool DataReductionProxyConfig::IsDataReductionProxy(
 
   const std::vector<net::ProxyServer>& proxy_list =
       config_values_->proxies_for_http();

[RyanSturm, 2016/10/17 18:57:22]

proxies_for_http() frustrates me. Either we have a seperate lists of
ProxyServers for different schemes or we have one list of HostPortPairs.

This is fine for the merge, but can you open a bug on this, so it gets fixed at
some point.

[tbansal1, 2016/10/17 19:06:52]

We used to have proxies_for_https() in the past for CONNECT jobs. Later, we
removed the code. We are not yet 100% confident that we will not bring that code
back. So, it might be too premature to refactor this to a different name.

+
+  net::HostPortPair host_port_pair = proxy_server.host_port_pair();
   const auto proxy_it =
-      std::find(proxy_list.begin(), proxy_list.end(), proxy_server);
+      std::find_if(proxy_list.begin(), proxy_list.end(),
+                   [&host_port_pair](const net::ProxyServer& proxy) {

[RyanSturm, 2016/10/17 18:57:22]

nit: I don't care if you change this or not, but since the scope of this lambda
means it will be short lived, you don't strictly need to capture host_port_pair
(instead you can just [&]). the style guide is ambiguous in this area as which
is preferred for short-lvied lambdas. 

https://google.github.io/styleguide/cppguide.html#Lambda_expressions

This is a total nit, and I don't care if you fix it; just a talking point.

[tbansal1, 2016/10/17 19:06:52]

Acknowledged.

+                     return proxy.is_valid() &&
+                            proxy.host_port_pair().Equals(host_port_pair);
+                   });
 
   if (proxy_it != proxy_list.end()) {
     if (proxy_info) {