Add ReferrerPolicy support to preload

third_party/WebKit/Source/platform/network/LinkHeaderTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/network/LinkHeader.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include <base/macros.h>
 
 namespace blink {
 namespace {
 
 TEST(LinkHeaderTest, Empty) {
   String nullString;
   LinkHeaderSet nullHeaderSet(nullString);
   ASSERT_EQ(nullHeaderSet.size(), unsigned(0));
   String emptyString("");
   LinkHeaderSet emptyHeaderSet(emptyString);
   ASSERT_EQ(emptyHeaderSet.size(), unsigned(0));
 }
 
 struct SingleTestCase {
   const char* headerValue;
   bool valid;
   const char* url;
   const char* rel;
   const char* as;
   const char* media;
+  const char* referrerPolicy;
 } singleTestCases[] = {
     {"</images/cat.jpg>; rel=prefetch", true, "/images/cat.jpg", "prefetch", "",
      ""},
     {"</images/cat.jpg>;rel=prefetch", true, "/images/cat.jpg", "prefetch", "",
      ""},
     {"</images/cat.jpg>   ;rel=prefetch", true, "/images/cat.jpg", "prefetch",
      "", ""},
     {"</images/cat.jpg>   ;   rel=prefetch", true, "/images/cat.jpg",
      "prefetch", "", ""},
     {"< /images/cat.jpg>   ;   rel=prefetch", true, "/images/cat.jpg",
@@ skipping 104 matching lines @@
     {"<http://whatever.com>; rel=preconnect; valid$", true,
      "http://whatever.com", "preconnect", "", ""},
     {"<http://whatever.com>; rel=preconnect; invalid@", false},
     {"<http://whatever.com>; rel=preconnect; invalid*", false},
     {"</images/cat.jpg>; rel=prefetch;media='(max-width: 5000px)'", true,
      "/images/cat.jpg", "prefetch", "", "'(max-width: 5000px)'"},
     {"</images/cat.jpg>; rel=prefetch;media=\"(max-width: 5000px)\"", true,
      "/images/cat.jpg", "prefetch", "", "(max-width: 5000px)"},
     {"</images/cat.jpg>; rel=prefetch;media=(max-width:5000px)", true,
      "/images/cat.jpg", "prefetch", "", "(max-width:5000px)"},
+    {"</images/cat.jpg>; rel=preload;referrerpolicy=somevalue", true,

[Mike West, 2016/10/23 05:25:46]

I guess this is a reasonable addition, but it needs to be specified somewhere.
We should probably also be taking the `referrer-policy` header into account
(which, again, is an argument for specifying the behavior somewhere :) ).

[Yoav Weiss, 2016/10/23 13:27:09]

I considered it as a "link-extension" defined in
https://tools.ietf.org/html/rfc5988#section-5 (Similar to what we do with `as`
and the way the `nopush` attribute is being used (even if browsers don't really
need to support it).

Do you think we need to define it (and other new attributes) explicitly? If so,
I'll be happy do that.

I assumed the header is being taken into account in the code that consumes that
header (as the document's referrer policy). A test wouldn't hurt tho 

+     "/images/cat.jpg", "preload", "", "", "somevalue"},

[Mike West, 2016/10/23 05:25:46]

I don't understand how this test works. You've added a `referrerPolicy` value,
but it doesn't look like you're checking it anywhere? And you haven't added the
value to any other item in the list?

[Yoav Weiss, 2016/10/23 13:27:09]

my bad. Forgot to add an actual check for the value :/

 };
 
 void PrintTo(const SingleTestCase& test, std::ostream* os) {
   *os << ::testing::PrintToString(test.headerValue);
 }
 
 class SingleLinkHeaderTest : public ::testing::TestWithParam<SingleTestCase> {};
 
 // Test the cases with a single header
 TEST_P(SingleLinkHeaderTest, Single) {
@@ skipping 115 matching lines @@
   else
     EXPECT_STREQ(testCase.crossorigin, header.crossOrigin().ascii().data());
 }
 
 INSTANTIATE_TEST_CASE_P(LinkHeaderTest,
                         CrossOriginLinkHeaderTest,
                         testing::ValuesIn(crossOriginTestCases));
 
 }  // namespace
 }  // namespace blink