Add ReferrerPolicy support to preload

third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/loader/LinkLoader.h"
 
 #include "core/fetch/MemoryCache.h"
 #include "core/fetch/ResourceFetcher.h"
 #include "core/frame/Settings.h"
 #include "core/html/LinkRelAttribute.h"
@@ skipping 65 matching lines @@
   mutable bool m_isHTTPS;
   mutable bool m_isCrossOrigin;
 };
 
 TEST(LinkLoaderTest, Preload) {
   struct TestCase {
     const char* href;
     const char* as;
     const char* type;
     const char* media;
+    const char* referrerPolicy;
     const ResourceLoadPriority priority;
     const WebURLRequest::RequestContext context;
     const bool linkLoaderShouldLoadValue;
     const bool expectingLoad;
+    const ReferrerPolicy expectedReferrerPolicy;
   } cases[] = {
-      {"http://example.test/cat.jpg", "image", "", "", ResourceLoadPriorityLow,
-       WebURLRequest::RequestContextImage, true, true},
-      {"http://example.test/cat.js", "script", "", "", ResourceLoadPriorityHigh,
-       WebURLRequest::RequestContextScript, true, true},
-      {"http://example.test/cat.css", "style", "", "",
+      {"http://example.test/cat.jpg", "image", "", "", "",
+       ResourceLoadPriorityLow, WebURLRequest::RequestContextImage, true, true,
+       ReferrerPolicyDefault},
+      {"http://example.test/cat.js", "script", "", "", "",
+       ResourceLoadPriorityHigh, WebURLRequest::RequestContextScript, true,
+       true, ReferrerPolicyDefault},
+      {"http://example.test/cat.css", "style", "", "", "",
        ResourceLoadPriorityVeryHigh, WebURLRequest::RequestContextStyle, true,
-       true},
+       true, ReferrerPolicyDefault},
       // TODO(yoav): It doesn't seem like the audio context is ever used. That should probably be fixed (or we can consolidate audio and video).
-      {"http://example.test/cat.wav", "media", "", "", ResourceLoadPriorityLow,
-       WebURLRequest::RequestContextVideo, true, true},
-      {"http://example.test/cat.mp4", "media", "", "", ResourceLoadPriorityLow,
-       WebURLRequest::RequestContextVideo, true, true},
-      {"http://example.test/cat.vtt", "track", "", "", ResourceLoadPriorityLow,
-       WebURLRequest::RequestContextTrack, true, true},
-      {"http://example.test/cat.woff", "font", "", "",
+      {"http://example.test/cat.wav", "media", "", "", "",
+       ResourceLoadPriorityLow, WebURLRequest::RequestContextVideo, true, true,
+       ReferrerPolicyDefault},
+      {"http://example.test/cat.mp4", "media", "", "", "",
+       ResourceLoadPriorityLow, WebURLRequest::RequestContextVideo, true, true,
+       ReferrerPolicyDefault},
+      {"http://example.test/cat.vtt", "track", "", "", "",
+       ResourceLoadPriorityLow, WebURLRequest::RequestContextTrack, true, true,
+       ReferrerPolicyDefault},
+      {"http://example.test/cat.woff", "font", "", "", "",
        ResourceLoadPriorityVeryHigh, WebURLRequest::RequestContextFont, true,
-       true},
+       true, ReferrerPolicyDefault},
       // TODO(yoav): subresource should be *very* low priority (rather than low).
-      {"http://example.test/cat.empty", "", "", "", ResourceLoadPriorityHigh,
-       WebURLRequest::RequestContextSubresource, true, true},
-      {"http://example.test/cat.blob", "blabla", "", "",
+      {"http://example.test/cat.empty", "", "", "", "",
+       ResourceLoadPriorityHigh, WebURLRequest::RequestContextSubresource, true,
+       true, ReferrerPolicyDefault},
+      {"http://example.test/cat.blob", "blabla", "", "", "",
        ResourceLoadPriorityLow, WebURLRequest::RequestContextSubresource, false,
-       false},
-      {"bla://example.test/cat.gif", "image", "", "",
+       false, ReferrerPolicyDefault},
+      {"bla://example.test/cat.gif", "image", "", "", "",
        ResourceLoadPriorityUnresolved, WebURLRequest::RequestContextImage,
-       false, false},
+       false, false, ReferrerPolicyDefault},
       // MIME type tests
-      {"http://example.test/cat.webp", "image", "image/webp", "",
-       ResourceLoadPriorityLow, WebURLRequest::RequestContextImage, true, true},
-      {"http://example.test/cat.svg", "image", "image/svg+xml", "",
-       ResourceLoadPriorityLow, WebURLRequest::RequestContextImage, true, true},
-      {"http://example.test/cat.jxr", "image", "image/jxr", "",
+      {"http://example.test/cat.webp", "image", "image/webp", "", "",
+       ResourceLoadPriorityLow, WebURLRequest::RequestContextImage, true, true,
+       ReferrerPolicyDefault},
+      {"http://example.test/cat.svg", "image", "image/svg+xml", "", "",
+       ResourceLoadPriorityLow, WebURLRequest::RequestContextImage, true, true,
+       ReferrerPolicyDefault},
+      {"http://example.test/cat.jxr", "image", "image/jxr", "", "",
        ResourceLoadPriorityUnresolved, WebURLRequest::RequestContextImage,
-       false, false},
-      {"http://example.test/cat.js", "script", "text/javascript", "",
+       false, false, ReferrerPolicyDefault},
+      {"http://example.test/cat.js", "script", "text/javascript", "", "",
        ResourceLoadPriorityHigh, WebURLRequest::RequestContextScript, true,
-       true},
-      {"http://example.test/cat.js", "script", "text/coffeescript", "",
+       true, ReferrerPolicyDefault},
+      {"http://example.test/cat.js", "script", "text/coffeescript", "", "",
        ResourceLoadPriorityUnresolved, WebURLRequest::RequestContextScript,
-       false, false},
-      {"http://example.test/cat.css", "style", "text/css", "",
+       false, false, ReferrerPolicyDefault},
+      {"http://example.test/cat.css", "style", "text/css", "", "",
        ResourceLoadPriorityVeryHigh, WebURLRequest::RequestContextStyle, true,
-       true},
-      {"http://example.test/cat.css", "style", "text/sass", "",
+       true, ReferrerPolicyDefault},
+      {"http://example.test/cat.css", "style", "text/sass", "", "",
        ResourceLoadPriorityUnresolved, WebURLRequest::RequestContextStyle,
-       false, false},
-      {"http://example.test/cat.wav", "media", "audio/wav", "",
-       ResourceLoadPriorityLow, WebURLRequest::RequestContextVideo, true, true},
-      {"http://example.test/cat.wav", "media", "audio/mp57", "",
+       false, false, ReferrerPolicyDefault},
+      {"http://example.test/cat.wav", "media", "audio/wav", "", "",
+       ResourceLoadPriorityLow, WebURLRequest::RequestContextVideo, true, true,
+       ReferrerPolicyDefault},
+      {"http://example.test/cat.wav", "media", "audio/mp57", "", "",
        ResourceLoadPriorityUnresolved, WebURLRequest::RequestContextVideo,
-       false, false},
-      {"http://example.test/cat.webm", "media", "video/webm", "",
-       ResourceLoadPriorityLow, WebURLRequest::RequestContextVideo, true, true},
-      {"http://example.test/cat.mp199", "media", "video/mp199", "",
+       false, false, ReferrerPolicyDefault},
+      {"http://example.test/cat.webm", "media", "video/webm", "", "",
+       ResourceLoadPriorityLow, WebURLRequest::RequestContextVideo, true, true,
+       ReferrerPolicyDefault},
+      {"http://example.test/cat.mp199", "media", "video/mp199", "", "",
        ResourceLoadPriorityUnresolved, WebURLRequest::RequestContextVideo,
-       false, false},
-      {"http://example.test/cat.vtt", "track", "text/vtt", "",
-       ResourceLoadPriorityLow, WebURLRequest::RequestContextTrack, true, true},
-      {"http://example.test/cat.vtt", "track", "text/subtitlething", "",
+       false, false, ReferrerPolicyDefault},
+      {"http://example.test/cat.vtt", "track", "text/vtt", "", "",
+       ResourceLoadPriorityLow, WebURLRequest::RequestContextTrack, true, true,
+       ReferrerPolicyDefault},
+      {"http://example.test/cat.vtt", "track", "text/subtitlething", "", "",
        ResourceLoadPriorityUnresolved, WebURLRequest::RequestContextTrack,
-       false, false},
-      {"http://example.test/cat.woff", "font", "font/woff2", "",
+       false, false, ReferrerPolicyDefault},
+      {"http://example.test/cat.woff", "font", "font/woff2", "", "",
        ResourceLoadPriorityVeryHigh, WebURLRequest::RequestContextFont, true,
-       true},
-      {"http://example.test/cat.woff", "font", "font/woff84", "",
+       true, ReferrerPolicyDefault},
+      {"http://example.test/cat.woff", "font", "font/woff84", "", "",
        ResourceLoadPriorityUnresolved, WebURLRequest::RequestContextFont, false,
-       false},
-      {"http://example.test/cat.empty", "", "foo/bar", "",
+       false, ReferrerPolicyDefault},
+      {"http://example.test/cat.empty", "", "foo/bar", "", "",
        ResourceLoadPriorityHigh, WebURLRequest::RequestContextSubresource, true,
-       true},
-      {"http://example.test/cat.blob", "blabla", "foo/bar", "",
+       true, ReferrerPolicyDefault},
+      {"http://example.test/cat.blob", "blabla", "foo/bar", "", "",
        ResourceLoadPriorityLow, WebURLRequest::RequestContextSubresource, false,
-       false},
+       false, ReferrerPolicyDefault},
       // Media tests
       {"http://example.test/cat.gif", "image", "image/gif",
-       "(max-width: 600px)", ResourceLoadPriorityLow,
-       WebURLRequest::RequestContextImage, true, true},
+       "(max-width: 600px)", "", ResourceLoadPriorityLow,
+       WebURLRequest::RequestContextImage, true, true, ReferrerPolicyDefault},
       {"http://example.test/cat.gif", "image", "image/gif",
-       "(max-width: 400px)", ResourceLoadPriorityUnresolved,
-       WebURLRequest::RequestContextImage, true, false},
+       "(max-width: 400px)", "", ResourceLoadPriorityUnresolved,
+       WebURLRequest::RequestContextImage, true, false, ReferrerPolicyDefault},
       {"http://example.test/cat.gif", "image", "image/gif",
-       "(max-width: 600px)", ResourceLoadPriorityLow,
-       WebURLRequest::RequestContextImage, false, false},
+       "(max-width: 600px)", "", ResourceLoadPriorityLow,
+       WebURLRequest::RequestContextImage, false, false, ReferrerPolicyDefault},
+      // Referrer Policy
+      {"http://example.test/cat.gif", "image", "image/gif", "", "origin",
+       ResourceLoadPriorityLow, WebURLRequest::RequestContextImage, false,
+       false, ReferrerPolicyOrigin},
+      {"http://example.test/cat.gif", "image", "image/gif", "",
+       "origin-when-crossorigin", ResourceLoadPriorityLow,
+       WebURLRequest::RequestContextImage, false, false,
+       ReferrerPolicyOriginWhenCrossOrigin},
+      {"http://example.test/cat.gif", "image", "image/gif", "", "no-referrer",
+       ResourceLoadPriorityLow, WebURLRequest::RequestContextImage, false,
+       false, ReferrerPolicyNever},
   };
 
   // Test the cases with a single header
   for (const auto& testCase : cases) {
     std::unique_ptr<DummyPageHolder> dummyPageHolder =
         DummyPageHolder::create(IntSize(500, 500));
     dummyPageHolder->frame().settings()->setScriptEnabled(true);
     Persistent<MockLinkLoaderClient> loaderClient =
         MockLinkLoaderClient::create(testCase.linkLoaderShouldLoadValue);
     LinkLoader* loader = LinkLoader::create(loaderClient.get());
     KURL hrefURL = KURL(KURL(), testCase.href);
     URLTestHelpers::registerMockedErrorURLLoad(hrefURL);
     loader->loadLink(LinkRelAttribute("preload"), CrossOriginAttributeNotSet,
-                     testCase.type, testCase.as, testCase.media, hrefURL,
+                     testCase.type, testCase.as, testCase.media,
+                     testCase.referrerPolicy, hrefURL,
                      dummyPageHolder->document(), NetworkHintsMock());
     ASSERT_TRUE(dummyPageHolder->document().fetcher());
     HeapListHashSet<Member<Resource>>* preloads =
         dummyPageHolder->document().fetcher()->preloads();
     if (testCase.expectingLoad) {
       if (!preloads)
         fprintf(stderr, "Unexpected result %s %s %s\n", testCase.href,
                 testCase.as, testCase.type);
       EXPECT_TRUE(preloads);
     } else {
       EXPECT_FALSE(preloads);
     }
     if (preloads) {
       if (testCase.priority == ResourceLoadPriorityUnresolved) {
         EXPECT_EQ(0u, preloads->size());
       } else {
         EXPECT_EQ(1u, preloads->size());
         if (preloads->size() > 0) {
           Resource* resource = preloads->begin().get()->get();
           EXPECT_EQ(testCase.priority, resource->resourceRequest().priority());
           EXPECT_EQ(testCase.context,
                     resource->resourceRequest().requestContext());

[estark, 2016/10/18 04:55:54]

Looks like this is missing an assertion about `expectedReferrerPolicy`.

         }
       }
       dummyPageHolder->document().fetcher()->clearPreloads();
     }
     memoryCache()->evictResources();
     Platform::current()->getURLLoaderMockFactory()->unregisterAllURLs();
   }
 }
 
 TEST(LinkLoaderTest, DNSPrefetch) {
@@ skipping 15 matching lines @@
     dummyPageHolder->document().settings()->setDNSPrefetchingEnabled(true);
     Persistent<MockLinkLoaderClient> loaderClient =
         MockLinkLoaderClient::create(testCase.shouldLoad);
     LinkLoader* loader = LinkLoader::create(loaderClient.get());
     KURL hrefURL =
         KURL(KURL(ParsedURLStringTag(), String("http://example.com")),
              testCase.href);
     NetworkHintsMock networkHints;
     loader->loadLink(LinkRelAttribute("dns-prefetch"),
                      CrossOriginAttributeNotSet, String(), String(), String(),
-                     hrefURL, dummyPageHolder->document(), networkHints);
+                     String(), hrefURL, dummyPageHolder->document(),
+                     networkHints);
     EXPECT_FALSE(networkHints.didPreconnect());
     EXPECT_EQ(testCase.shouldLoad, networkHints.didDnsPrefetch());
   }
 }
 
 TEST(LinkLoaderTest, Preconnect) {
   struct {
     const char* href;
     CrossOriginAttributeValue crossOrigin;
     const bool shouldLoad;
@@ skipping 11 matching lines @@
     std::unique_ptr<DummyPageHolder> dummyPageHolder =
         DummyPageHolder::create(IntSize(500, 500));
     Persistent<MockLinkLoaderClient> loaderClient =
         MockLinkLoaderClient::create(testCase.shouldLoad);
     LinkLoader* loader = LinkLoader::create(loaderClient.get());
     KURL hrefURL =
         KURL(KURL(ParsedURLStringTag(), String("http://example.com")),
              testCase.href);
     NetworkHintsMock networkHints;
     loader->loadLink(LinkRelAttribute("preconnect"), testCase.crossOrigin,
-                     String(), String(), String(), hrefURL,
+                     String(), String(), String(), String(), hrefURL,
                      dummyPageHolder->document(), networkHints);
     EXPECT_EQ(testCase.shouldLoad, networkHints.didPreconnect());
     EXPECT_EQ(testCase.isHTTPS, networkHints.isHTTPS());
     EXPECT_EQ(testCase.isCrossOrigin, networkHints.isCrossOrigin());
   }
 }
 
 }  // namespace blink