Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2424933003: Rename ValueSet* to HistogramSet*. (Closed)

Created:
4 years, 2 months ago by benjhayden
Modified:
4 years, 2 months ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 : . #

Patch Set 2 : rebase #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -2423 lines) Patch
M docs/how-to-write-metrics.md View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/bin/results2json View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M tracing/bin/valueset2html View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M tracing/trace_viewer.gypi View 1 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/extras/chrome/estimated_input_latency.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/metrics/blink/gc_metric_test.html View 5 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/metrics/compare_samples_cmdline.html View 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/metrics/cpu_process_metric_test.html View 4 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/metrics/metric_map_function.html View 5 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/metrics/metric_registry.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/metrics/system_health/clock_sync_latency_metric_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/metrics/system_health/cpu_time_metric.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/metrics/system_health/cpu_time_metric_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/metrics/system_health/hazard_metric_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/metrics/system_health/loading_metric_test.html View 6 chunks +6 lines, -6 lines 0 comments Download
M tracing/tracing/metrics/system_health/long_tasks_metric.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/metrics/system_health/long_tasks_metric_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/metrics/system_health/memory_metric.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/metrics/system_health/memory_metric_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/metrics/system_health/power_metric.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/metrics/system_health/power_metric_test.html View 17 chunks +17 lines, -17 lines 0 comments Download
M tracing/tracing/metrics/system_health/responsiveness_metric.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/metrics/system_health/responsiveness_metric_test.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/metrics/system_health/webview_startup_metric_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/metrics/tracing_metric_test.html View 6 chunks +6 lines, -6 lines 0 comments Download
M tracing/tracing/metrics/v8/execution_metric_test.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/metrics/v8/gc_metric_test.html View 8 chunks +8 lines, -8 lines 0 comments Download
M tracing/tracing/results2_template.html View 1 4 chunks +8 lines, -8 lines 0 comments Download
M tracing/tracing/ui/analysis/single_user_expectation_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/side_panel/metrics_side_panel.html View 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/value/diagnostics/related_histogram_breakdown.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/value/diagnostics/related_histogram_breakdown_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/value/diagnostics/related_value_map.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/value/diagnostics/related_value_set.html View 1 chunk +1 line, -1 line 0 comments Download
A + tracing/tracing/value/histogram_set.html View 5 chunks +5 lines, -5 lines 0 comments Download
A + tracing/tracing/value/histogram_set_test.html View 6 chunks +10 lines, -10 lines 0 comments Download
A + tracing/tracing/value/ui/histogram_set_table.html View 1 21 chunks +43 lines, -42 lines 0 comments Download
A + tracing/tracing/value/ui/histogram_set_table_test.html View 29 chunks +68 lines, -67 lines 0 comments Download
A + tracing/tracing/value/ui/histogram_set_view.html View 4 chunks +7 lines, -7 lines 0 comments Download
A + tracing/tracing/value/ui/histogram_set_view_test.html View 1 chunk +7 lines, -7 lines 0 comments Download
D tracing/tracing/value/ui/value_set_table.html View 1 1 chunk +0 lines, -962 lines 0 comments Download
D tracing/tracing/value/ui/value_set_table_test.html View 1 chunk +0 lines, -544 lines 0 comments Download
D tracing/tracing/value/ui/value_set_view.html View 1 chunk +0 lines, -209 lines 0 comments Download
D tracing/tracing/value/ui/value_set_view_test.html View 1 chunk +0 lines, -30 lines 0 comments Download
D tracing/tracing/value/value_set.html View 1 chunk +0 lines, -248 lines 0 comments Download
D tracing/tracing/value/value_set_test.html View 1 chunk +0 lines, -186 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
benjhayden
PTAL :-)
4 years, 2 months ago (2016-10-17 23:20:21 UTC) #3
eakuefner
lgtm
4 years, 2 months ago (2016-10-20 16:43:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424933003/60001
4 years, 2 months ago (2016-10-20 17:03:34 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-20 17:27:15 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698