Register existing isolates when service isolate is started

runtime/vm/service.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/service.h"
 
 #include "include/dart_api.h"
 #include "platform/globals.h"
 
 #include "vm/compiler.h"
@@ skipping 233 matching lines @@
   const Object& rp_id_obj = Object::Handle(DartLibraryCalls::PortGetId(rp));
   if (rp_id_obj.IsError()) {
     return ILLEGAL_PORT;
   }
   ASSERT(rp_id_obj.IsSmi() || rp_id_obj.IsMint());
   const Integer& id = Integer::Cast(rp_id_obj);
   return static_cast<Dart_Port>(id.AsInt64Value());
 }
 
 
+// These must be kept in sync with service/constants.dart
+#define VM_SERVICE_ISOLATE_STARTUP_MESSAGE_ID 1
+#define VM_SERVICE_ISOLATE_SHUTDOWN_MESSAGE_ID 2
+
+
+static RawArray* MakeServiceControlMessage(Dart_Port port_id, intptr_t code,
+                                           const String& name) {
+  const Array& list = Array::Handle(Array::New(4));
+  ASSERT(!list.IsNull());
+  const Integer& code_int = Integer::Handle(Integer::New(code));
+  const Integer& port_int = Integer::Handle(Integer::New(port_id));
+  const Object& send_port = Object::Handle(
+      DartLibraryCalls::NewSendPort(port_id));
+  ASSERT(!send_port.IsNull());
+  list.SetAt(0, code_int);
+  list.SetAt(1, port_int);
+  list.SetAt(2, send_port);
+  list.SetAt(3, name);
+  return list.raw();
+}
+
+
+class RegisterRunningIsolatesVisitor : public IsolateVisitor {
+ public:
+  explicit RegisterRunningIsolatesVisitor(Isolate* service_isolate)
+      : IsolateVisitor(),
+        service_isolate_(service_isolate) {
+  }
+
+  virtual void VisitIsolate(Isolate* isolate) {
+    if ((isolate == service_isolate_) ||
+        (isolate == Dart::vm_isolate())) {
+      // We do not register ourselves or the vm isolate.
+      return;
+    }
+    ASSERT(Isolate::Current() == service_isolate_);
+    // Get library.
+    const String& library_url = Symbols::DartVMService();
+    ASSERT(!library_url.IsNull());
+    const Library& library =
+        Library::Handle(Library::LookupLibrary(library_url));
+    ASSERT(!library.IsNull());
+    // Get function.
+    const String& function_name =
+        String::Handle(String::New("_registerIsolate"));
+    ASSERT(!function_name.IsNull());
+    const Function& function =
+        Function::Handle(library.LookupFunctionAllowPrivate(function_name));
+    ASSERT(!function.IsNull());

[siva, 2014/04/21 21:27:53]

Can the lookup of this top level function _registerIsolate be done once in the
constructor and then the function used in VisitIsolate()?

This can turn out to be expensive if the number of isolates is large.

[Cutch, 2014/04/21 22:00:40]

Done.

+    // Create ServiceControlMessage.
+    const String& name = String::Handle(String::New(isolate->name()));
+    ASSERT(!name.IsNull());
+    const Array& list = Array::Handle(
+        MakeServiceControlMessage(isolate->main_port(),
+                                  VM_SERVICE_ISOLATE_STARTUP_MESSAGE_ID,
+                                  name));
+    // Setup arguments for call.
+    const Array& args = Array::Handle(Array::New(1));
+    ASSERT(!args.IsNull());
+    args.SetAt(0, list);
+    const Object& r = Object::Handle(DartEntry::InvokeFunction(function, args));
+    ASSERT(!r.IsError());
+  }
+
+ private:
+  Isolate* service_isolate_;
+};
+
+
 Isolate* Service::GetServiceIsolate(void* callback_data) {
   if (service_isolate_ != NULL) {
     // Already initialized, return service isolate.
     return service_isolate_;
   }
   Dart_ServiceIsolateCreateCalback create_callback =
     Isolate::ServiceCreateCallback();
   if (create_callback == NULL) {
     return NULL;
   }
@@ skipping 57 matching lines @@
     Dart_Handle url_str =
         Dart_NewStringFromCString(Symbols::Name(Symbols::kDartVMServiceId));
     Dart_Handle library = Dart_LookupLibrary(url_str);
     ASSERT(Dart_IsLibrary(library));
     result = Dart_Invoke(library, Dart_NewStringFromCString("boot"), 0, NULL);
     ASSERT(!Dart_IsError(result));
     port_ = ExtractPort(result);
     ASSERT(port_ != ILLEGAL_PORT);
     Dart_ExitScope();
   }
+  {
+    // Register existing isolates.
+    StackZone zone(isolate);
+    HANDLESCOPE(isolate);
+    RegisterRunningIsolatesVisitor register_isolates(isolate);
+    Isolate::VisitIsolates(&register_isolates);
+  }
   Isolate::SetCurrent(NULL);
   service_isolate_ = reinterpret_cast<Isolate*>(isolate);
   return service_isolate_;
 }
 
 
-// These must be kept in sync with service/constants.dart
-#define VM_SERVICE_ISOLATE_STARTUP_MESSAGE_ID 1
-#define VM_SERVICE_ISOLATE_SHUTDOWN_MESSAGE_ID 2
-
-
-static RawArray* MakeServiceControlMessage(Dart_Port port_id, intptr_t code,
-                                           const String& name) {
-  const Array& list = Array::Handle(Array::New(4));
-  ASSERT(!list.IsNull());
-  const Integer& code_int = Integer::Handle(Integer::New(code));
-  const Integer& port_int = Integer::Handle(Integer::New(port_id));
-  const Object& send_port = Object::Handle(
-      DartLibraryCalls::NewSendPort(port_id));
-  ASSERT(!send_port.IsNull());
-  list.SetAt(0, code_int);
-  list.SetAt(1, port_int);
-  list.SetAt(2, send_port);
-  list.SetAt(3, name);
-  return list.raw();
-}
-
-
 bool Service::SendIsolateStartupMessage() {
   if (!IsRunning()) {
     return false;
   }
   Isolate* isolate = Isolate::Current();
   ASSERT(isolate != NULL);
   HANDLESCOPE(isolate);
   const String& name = String::Handle(String::New(isolate->name()));
   ASSERT(!name.IsNull());
   const Array& list = Array::Handle(
@@ skipping 1531 matching lines @@
   while (current != NULL) {
     if (strcmp(name, current->name()) == 0) {
       return current;
     }
     current = current->next();
   }
   return NULL;
 }
 
 }  // namespace dart