Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Unified Diff: content/common/navigation_params.cc

Issue 2424913003: Avoid unnecessary URL parsing for GURL comparisons in //content (Closed)
Patch Set: rebase on dependent PS Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/navigation_params.cc
diff --git a/content/common/navigation_params.cc b/content/common/navigation_params.cc
index ceea4aa9a5b40fde949c59fdfb41e97378ee68eb..5b49864eb9ccaf473f7d75c8775f8feac405c76b 100644
--- a/content/common/navigation_params.cc
+++ b/content/common/navigation_params.cc
@@ -22,10 +22,9 @@ bool ShouldMakeNetworkRequestForURL(const GURL& url) {
// to the network stack.
// TODO(clamy): same document navigations should not send requests to the
// network stack. Neither should pushState/popState.
- return url != GURL(url::kAboutBlankURL) &&
- !url.SchemeIs(url::kJavaScriptScheme) && !url.is_empty() &&
- !url.SchemeIs(url::kContentIDScheme) &&
- url != GURL(content::kAboutSrcDocURL);
+ return url != url::kAboutBlankURL && !url.SchemeIs(url::kJavaScriptScheme) &&
+ !url.is_empty() && !url.SchemeIs(url::kContentIDScheme) &&
+ url != content::kAboutSrcDocURL;
}
CommonNavigationParams::CommonNavigationParams()
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698