Renaming package names to use no spaces.

Renaming package names to use no spaces.

BUG=656791
R=jamiewalch@chromium.org

Committed: https://crrev.com/9e01f1257eb75274157fe7d246869b32d24b155b
Cr-Commit-Position: refs/heads/master@{#425838}

[nicholss, 2016-10-17 22:23:03]

Patchset #1 (id:1) has been deleted

[nicholss, 2016-10-17 22:23:28]

PTAL

[Jamie, 2016-10-17 22:57:45]

lgtm

https://codereview.chromium.org/2424893003/diff/20001/remoting/host/installer...
File remoting/host/installer/mac/BUILD.gn (left):

https://codereview.chromium.org/2424893003/diff/20001/remoting/host/installer...
remoting/host/installer/mac/BUILD.gn:53: # TODO(GYP) TODO(crbug.com/622415):
Fill these in.
Please update/close crbug.com/622415 as appropriate (I can't access it right now
to check what this bug actually is).

[nicholss, 2016-10-17 23:08:39]

On 2016/10/17 22:57:45, Jamie wrote:
> lgtm
> 
>
https://codereview.chromium.org/2424893003/diff/20001/remoting/host/installer...
> File remoting/host/installer/mac/BUILD.gn (left):
> 
>
https://codereview.chromium.org/2424893003/diff/20001/remoting/host/installer...
> remoting/host/installer/mac/BUILD.gn:53: # TODO(GYP) TODO(crbug.com/622415):
> Fill these in.
> Please update/close crbug.com/622415 as appropriate (I can't access it right
now
> to check what this bug actually is).

it has been closed already.

[nicholss, 2016-10-17 23:08:48]

The CQ bit was checked by nicholss@chromium.org

[Lambros, 2016-10-17 23:09:19]

lambroslambrou@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[Lambros, 2016-10-17 23:09:20]

https://codereview.chromium.org/2424893003/diff/20001/remoting/remoting_versi...
File remoting/remoting_version.gni (right):

https://codereview.chromium.org/2424893003/diff/20001/remoting/remoting_versi...
remoting/remoting_version.gni:81: host_name_nospace =
exec_script("//remoting/tools/remove_spaces.py",
Do we need these exec_script() calls? IIRC, Chrome is trying to eradicate
exec_script() ?
If $host_name and $host_service_name are constant strings, maybe we should just
add new constants: $host_name_no_space ... ?

[commit-bot: I haz the power, 2016-10-17 23:09:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nicholss, 2016-10-17 23:10:43]

On 2016/10/17 23:09:20, Lambros wrote:
>
https://codereview.chromium.org/2424893003/diff/20001/remoting/remoting_versi...
> File remoting/remoting_version.gni (right):
> 
>
https://codereview.chromium.org/2424893003/diff/20001/remoting/remoting_versi...
> remoting/remoting_version.gni:81: host_name_nospace =
> exec_script("//remoting/tools/remove_spaces.py",
> Do we need these exec_script() calls? IIRC, Chrome is trying to eradicate
> exec_script() ?
> If $host_name and $host_service_name are constant strings, maybe we should
just
> add new constants: $host_name_no_space ... ?

They come from the branding files, we would have to pipe it in from there.
Because these run in the gni file, they only get executed once per build
generation.

But yes, it could be done later.

[commit-bot: I haz the power, 2016-10-18 00:45:44]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-10-18 00:48:33]

Description was changed from

==========
Renaming package names to use no spaces.

BUG=656791

R=jamiewalch@chromium.org
==========

to

==========
Renaming package names to use no spaces.

BUG=656791

R=jamiewalch@chromium.org

Committed: https://crrev.com/9e01f1257eb75274157fe7d246869b32d24b155b
Cr-Commit-Position: refs/heads/master@{#425838}
==========

[commit-bot: I haz the power, 2016-10-18 00:48:34]

Patchset 1 (id:??) landed as
https://crrev.com/9e01f1257eb75274157fe7d246869b32d24b155b
Cr-Commit-Position: refs/heads/master@{#425838}