Issue 2424863002: Automated g4 rollback of internal changelist 134345701

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2424863002: Automated g4 rollback of internal changelist 134345701 (Closed)

Created:
4 years, 2 months ago by alyssar1

Modified:
4 years, 2 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Automated g4 rollback of internal changelist 134345701 *** Reason for rollback *** This has a bug that causes busy looping in chromium. *** Original change description *** bugfix for forced head of line blocking experiment. Guarded by ENABLED --FLAGS_FLAGS_quic_bugfix_fhol_writev_fin_only. Fix bug in FHOL, where fin-only writev caused cpu-spinning in gfe. Also changes the behaviour of FHOL to limit additional buffering to one HTTP/2 Data frame. Merge internal change: 135689007 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -197 lines)			Patch
M	net/quic/core/quic_headers_stream.h	View	1 chunk	+2 lines, -7 lines	0 comments	Download
M	net/quic/core/quic_headers_stream.cc	View	2 chunks	+40 lines, -103 lines	0 comments	Download
M	net/quic/core/quic_headers_stream_test.cc	View	2 chunks	+0 lines, -69 lines	0 comments	Download
M	net/quic/core/quic_spdy_session.cc	View	1 chunk	+6 lines, -18 lines	0 comments	Download

Dependent Patchsets:

Issue 2428623002 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

4 years, 2 months ago (2016-10-17 19:06:07 UTC) #2

LGTM. (Might want to tweak the CL description in the final CL)

Expand Messages | Collapse Messages