Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 2424833003: gpu: check GL_RGB565 work in ES3 context (Closed)

Created:
4 years, 2 months ago by dshwang
Modified:
4 years, 2 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: check GL_RGB565 work in ES3 context BUG=535198 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4 lines) Patch
M gpu/command_buffer/service/feature_info.h View 2 chunks +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager_unittest.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/test_helper.h View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/test_helper.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
dshwang
https://codereview.chromium.org/2117183006/ reduced test coverage, so this CL recover the test coverage. Zhenyao, it requires additional ...
4 years, 2 months ago (2016-10-17 15:20:22 UTC) #5
Zhenyao Mo
On 2016/10/17 15:20:22, dshwang wrote: > https://codereview.chromium.org/2117183006/ reduced test coverage, so this CL > recover ...
4 years, 2 months ago (2016-10-17 20:01:25 UTC) #8
dshwang
4 years, 2 months ago (2016-10-18 11:32:08 UTC) #9
On 2016/10/17 20:01:25, Zhenyao Mo wrote:
> On 2016/10/17 15:20:22, dshwang wrote:
> > https://codereview.chromium.org/2117183006/ reduced test coverage, so this
CL
> > recover the test coverage.
> > 
> > Zhenyao, it requires additional testing code in production code. do you
think
> > it's worth to add or just rely on webgl2 conformance test?
> 
> Let's not worry about this.  Command buffer unit tests will soon be obsolete
> when we switch to MANGLE.  Not worth your time, especially we do have coverage
> of this with WebGL2 conformance tests.

got it. let me abandon it.

Powered by Google App Engine
This is Rietveld 408576698