Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3693)

Unified Diff: chrome/browser/ui/webui/chromeos/login/network_state_informer.cc

Issue 242483003: Move CaptivePortalDetector to src/components/captive_portal (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move CaptivePortalDetector to a component Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/network_state_informer.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/network_state_informer.cc b/chrome/browser/ui/webui/chromeos/login/network_state_informer.cc
index 1c20bd1c3e3fde6fcd66d8260d0f79ef3ca6795e..3bca8ae539864be034fd7520d1095996a9ab141d 100644
--- a/chrome/browser/ui/webui/chromeos/login/network_state_informer.cc
+++ b/chrome/browser/ui/webui/chromeos/login/network_state_informer.cc
@@ -50,26 +50,26 @@ NetworkStateInformer::State GetStateForDefaultNetwork() {
if (NetworkPortalDetector::Get()->IsEnabled()) {
NetworkPortalDetector::CaptivePortalState state =
NetworkPortalDetector::Get()->GetCaptivePortalState(network->path());
- NetworkPortalDetector::CaptivePortalStatus status = state.status;
- if (status == NetworkPortalDetector::CAPTIVE_PORTAL_STATUS_UNKNOWN &&
+ captive_portal::CaptivePortalStatus status = state.status;
+ if (status == captive_portal::CAPTIVE_PORTAL_STATUS_UNKNOWN &&
NetworkState::StateIsConnecting(network->connection_state())) {
return NetworkStateInformer::CONNECTING;
}
// For proxy-less networks rely on shill's online state if
// NetworkPortalDetector's state of current network is unknown.
- if (status == NetworkPortalDetector::CAPTIVE_PORTAL_STATUS_ONLINE ||
- (status == NetworkPortalDetector::CAPTIVE_PORTAL_STATUS_UNKNOWN &&
+ if (status == captive_portal::CAPTIVE_PORTAL_STATUS_ONLINE ||
+ (status == captive_portal::CAPTIVE_PORTAL_STATUS_UNKNOWN &&
!HasDefaultNetworkProxyConfigured() &&
network->connection_state() == shill::kStateOnline)) {
return NetworkStateInformer::ONLINE;
}
if (status ==
- NetworkPortalDetector::CAPTIVE_PORTAL_STATUS_PROXY_AUTH_REQUIRED &&
+ captive_portal::CAPTIVE_PORTAL_STATUS_PROXY_AUTH_REQUIRED &&
HasDefaultNetworkProxyConfigured()) {
return NetworkStateInformer::PROXY_AUTH_REQUIRED;
}
- if (status == NetworkPortalDetector::CAPTIVE_PORTAL_STATUS_PORTAL ||
- (status == NetworkPortalDetector::CAPTIVE_PORTAL_STATUS_UNKNOWN &&
+ if (status == captive_portal::CAPTIVE_PORTAL_STATUS_PORTAL ||
+ (status == captive_portal::CAPTIVE_PORTAL_STATUS_UNKNOWN &&
network->connection_state() == shill::kStatePortal))
return NetworkStateInformer::CAPTIVE_PORTAL;
} else {

Powered by Google App Engine
This is Rietveld 408576698