chrome/browser/extensions/api/networking_private/networking_private_api_chromeos.cc - Issue 242483003: Move CaptivePortalDetector to src/components/captive_portal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_api_chromeos.cc

Issue 242483003: Move CaptivePortalDetector to src/components/captive_portal (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move CaptivePortalDetector to a component Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/captive_portal/captive_portal_service.cc ('K') | « chrome/browser/chromeos/net/network_portal_notification_controller_unittest.cc ('k') | chrome/browser/extensions/api/networking_private/networking_private_apitest.cc » ('j') | components/captive_portal/captive_portal_detector.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/networking_private/networking_private_api_chromeos.cc

diff --git a/chrome/browser/extensions/api/networking_private/networking_private_api_chromeos.cc b/chrome/browser/extensions/api/networking_private/networking_private_api_chromeos.cc

index d904f64f2271041afb54cc9c90405f443f9e5016..a18a91f6c61f7dd828a5ee26dcfa050de74f9b62 100644

--- a/chrome/browser/extensions/api/networking_private/networking_private_api_chromeos.cc

+++ b/chrome/browser/extensions/api/networking_private/networking_private_api_chromeos.cc

@@ -712,7 +712,7 @@ bool NetworkingPrivateGetCaptivePortalStatusFunction::RunImpl() {

detector->GetCaptivePortalState(params->network_path);

SetResult(new base::StringValue(

- NetworkPortalDetector::CaptivePortalStatusString(state.status)));

+ captive_portal::CaptivePortalStatusString(state.status)));

SendResponse(true);

return true;

}