chrome/browser/chromeos/net/network_portal_detector_impl.h - Issue 242483003: Move CaptivePortalDetector to src/components/captive_portal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/net/network_portal_detector_impl.h

Issue 242483003: Move CaptivePortalDetector to src/components/captive_portal (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move CaptivePortalStatus back Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/net/network_portal_detector_impl.h

diff --git a/chrome/browser/chromeos/net/network_portal_detector_impl.h b/chrome/browser/chromeos/net/network_portal_detector_impl.h

index 5faacab57678950c85823827b12cc98470b8dbab..abe0044f71c4eec3e63d148013b88ab471e91a83 100644

--- a/chrome/browser/chromeos/net/network_portal_detector_impl.h

+++ b/chrome/browser/chromeos/net/network_portal_detector_impl.h

@@ -17,11 +17,11 @@

#include "base/observer_list.h"

#include "base/threading/non_thread_safe.h"

#include "base/time/time.h"

-#include "chrome/browser/captive_portal/captive_portal_detector.h"

#include "chrome/browser/chromeos/net/network_portal_detector.h"

#include "chrome/browser/chromeos/net/network_portal_detector_strategy.h"

#include "chrome/browser/chromeos/net/network_portal_notification_controller.h"

#include "chromeos/network/network_state_handler_observer.h"

+#include "components/captive_portal/captive_portal_detector.h"

mmenke 2014/04/23 14:56:36 optional: While you're here, could just forward d

mmenke 2014/04/23 14:56:36 Should probably include captive_portal_types.h

stevenjb 2014/04/23 19:48:34 Actually, we need this for CaptivePortalDetector::

#include "content/public/browser/notification_observer.h"

#include "content/public/browser/notification_registrar.h"

#include "net/url_request/url_fetcher.h"