Move CaptivePortalDetector to src/components/captive_portal

chrome/browser/captive_portal/captive_portal_login_detector.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CAPTIVE_PORTAL_CAPTIVE_PORTAL_LOGIN_DETECTOR_H_
 #define CHROME_BROWSER_CAPTIVE_PORTAL_CAPTIVE_PORTAL_LOGIN_DETECTOR_H_
 
 #include "base/basictypes.h"
 #include "chrome/browser/captive_portal/captive_portal_service.h"
 
 class Profile;
 
 namespace captive_portal {

[mmenke, 2014/04/21 14:32:43]

Should we be using the namespace both in components/ and in chrome?  Not
familiar with what's usually done, just seems odd to me to have a namespace span
the two projects.

[stevenjb, 2014/04/21 16:42:27]

I've seen this done before (we definitely do it with chromoeos and ash, I feel
like I've seen it with other libraries). src/components contains the
non-chrome-specific library, and src/chrome contains the chrome specific parts.
I would be OK with removing the namespacing from src/chrome if there is a strong
preference for that.

[willchan no longer on Chromium, 2014/04/21 17:06:07]

I believe when we discussed this previously on chromium-dev@, we decided not to
use namespaces for chrome/ code. So I think we should only use this namespace
within components.

 
 // Triggers a captive portal test on navigations that may indicate a captive
 // portal has been logged into.  Currently only tracks if a page was opened
 // at a captive portal tab's login page, and triggers checks every navigation
 // until there's no longer a captive portal, relying on the
 // CaptivePortalService's throttling to prevent excessive server load.
 //
 // TODO(mmenke):  If a page has been broken by a captive portal, and it's
 // successfully reloaded, trigger a captive portal check.
 class CaptivePortalLoginDetector {
  public:
   explicit CaptivePortalLoginDetector(Profile* profile);
 
   ~CaptivePortalLoginDetector();
 
   void OnStoppedLoading();
-  void OnCaptivePortalResults(Result previous_result, Result result);
+  void OnCaptivePortalResults(CaptivePortalResult previous_result,
+                              CaptivePortalResult result);
 
   bool is_login_tab() const { return is_login_tab_; }
   void SetIsLoginTab();
 
  private:
   Profile* profile_;
 
   // True if this is a login tab.  Set manually, automatically cleared once
   // login is detected.
   bool is_login_tab_;
 
   // Page is on its first load since being tagged as a login tab.  Used to
   // prevent a second captive portal check on the first load of the login page.
   bool first_login_tab_load_;
 
   DISALLOW_COPY_AND_ASSIGN(CaptivePortalLoginDetector);
 };
 
 }  // namespace captive_portal
 
 #endif  // CHROME_BROWSER_CAPTIVE_PORTAL_CAPTIVE_PORTAL_LOGIN_DETECTOR_H_