Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2424823002: Implement collection of @viewport rules from DocumentStyleCollection. (Closed)

Created:
4 years, 2 months ago by rune
Modified:
4 years, 2 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, kenneth.christiansen, blink-reviews-style_chromium.org, blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement collection of @viewport rules from DocumentStyleCollection. The @viewport rules will be recollected and re-resolved from a new updateViewport() method. Rule will need to be re-collected when stylesheets are added, or when media queries change. Re-resolution needs to happen when the viewport descriptors contain vh/vw units, or after a re-collection of rules. Store the viewport and device dependent mq results on the ViewportStyleResolver as these may be different from the results collected when constructing the rulesets because of the initial/actual viewport difference. The device dependent will not be different, but nested media queries may cause some media queries to be skipped for ruleset construction which would not be skipped for @viewport rule collection. We also change the existing code to lazily reset() in preparation for the re-collect/re-resolve distinction. R=timloh@chromium.org BUG=567021 Committed: https://crrev.com/5f7120199c7334506d9384891532f864512ae3b8 Cr-Commit-Position: refs/heads/master@{#425942}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -10 lines) Patch
M third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.h View 2 chunks +20 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp View 8 chunks +95 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp View 1 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
rune
ptal
4 years, 2 months ago (2016-10-17 15:49:02 UTC) #5
Timothy Loh
lgtm
4 years, 2 months ago (2016-10-18 07:33:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424823002/1
4 years, 2 months ago (2016-10-18 08:50:05 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/283456)
4 years, 2 months ago (2016-10-18 08:56:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424823002/20001
4 years, 2 months ago (2016-10-18 09:35:13 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-18 11:52:29 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 11:53:49 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5f7120199c7334506d9384891532f864512ae3b8
Cr-Commit-Position: refs/heads/master@{#425942}

Powered by Google App Engine
This is Rietveld 408576698