Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2424813002: Avoid SkImage ref churn in short lived SkBitmapProvider (Closed)

Created:
4 years, 2 months ago by f(malita)
Modified:
4 years, 2 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Avoid SkImage ref churn in short lived SkBitmapProvider SkBitmapProvider is always stack-allocated and tightly-scoped. It should be safe to store a SkImage rawptr instead of a ref object. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2424813002 Committed: https://skia.googlesource.com/skia/+/862a3876086a9367c584598038887b94d8065fd7

Patch Set 1 #

Patch Set 2 : whitespace cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M src/core/SkBitmapProvider.h View 1 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
f(malita)
4 years, 2 months ago (2016-10-17 13:31:49 UTC) #2
reed1
that's wacky cool lgtm
4 years, 2 months ago (2016-10-17 13:45:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424813002/20001
4 years, 2 months ago (2016-10-17 13:55:41 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 14:16:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/862a3876086a9367c584598038887b94d8065fd7

Powered by Google App Engine
This is Rietveld 408576698