Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2424803002: lcms: Revise previous cmsStageAllocMatrix fix (Closed)

Created:
4 years, 2 months ago by kcwu
Modified:
4 years, 2 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

lcms: Revise previous cmsStageAllocMatrix fix Also fixed wrong patch file name. This is fixup of 958e57cb and d2023170 TEST=apply this change in lcms' repo and make check BUG=chromium:651849, chromium:654198 Committed: https://pdfium.googlesource.com/pdfium/+/522ed14ce8cf39e5e6fc1a58099edd4f849b7fb8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -31 lines) Patch
D third_party/lcms2-2.6/0009-cmdStageAllocMatrix-param-swap.patch View 1 chunk +0 lines, -26 lines 0 comments Download
A third_party/lcms2-2.6/0009-cmsStageAllocMatrix-param-swap.patch View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/lcms2-2.6/README.pdfium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/lcms2-2.6/src/cmslut.c View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/lcms2-2.6/src/cmstypes.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
kcwu
Sorry to attempt the fix again. I found previous fix will make lcms' own tests ...
4 years, 2 months ago (2016-10-17 13:27:37 UTC) #2
dsinclair
lgtm
4 years, 2 months ago (2016-10-17 13:29:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424803002/1
4 years, 2 months ago (2016-10-17 13:29:40 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 13:37:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/522ed14ce8cf39e5e6fc1a58099edd4f849b...

Powered by Google App Engine
This is Rietveld 408576698