Issue 2424783002: Add check for file:-navigations from PDFs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2424783002: Add check for file:-navigations from PDFs (Closed)

Created:
4 years, 2 months ago by robwu

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

Add check for file:-navigations from PDFs BUG=654279 TEST=./browser_tests --gtest_filter=PDFExtensionTest.Navigator CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2402873002 Cr-Commit-Position: refs/heads/master@{#425287} (cherry picked from commit 374249e767a68d8da073a4ed3a4f29236451174c) Committed: https://chromium.googlesource.com/chromium/src/+/c337558010508f6e27594e2683ddcf2f8813fc89

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -12 lines)			Patch
M	chrome/browser/resources/pdf/navigator.js	View	4 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/pdf/pdf.js	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/test/data/pdf/navigator_test.js	View	4 chunks	+39 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

robwu

4 years, 2 months ago (2016-10-17 11:57:44 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c337558010508f6e27594e2683ddcf2f8813fc89.