|
|
Created:
4 years, 2 months ago by marja Modified:
4 years, 2 months ago Reviewers:
Toon Verwaest CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionFix mjsunit oddities (new try).
1) assertInstanceOf(o, Foo, Bar) used to produce this error message:
Failure: expected <o> is not an instance of <Foo> but of < Bar>> found <undefined>
Fixed:
Failure: <o> is not an instance of <Foo> but of <Bar>
2) assertDoesNotThrow("throw 1") used to produce this error message:
Failure: expected <threw an exception: > found <1>
Fixed:
Failure: threw an exception: 1
3) assertDoesNotThrow("...", SomeError) was not doing what you'd
think it does, so removed the last parameter.
BUG=
Committed: https://crrev.com/e27ef0a60392ff2180b528e8d34d3bfb9f079319
Cr-Commit-Position: refs/heads/master@{#40347}
Patch Set 1 #
Created: 4 years, 2 months ago
Messages
Total messages: 12 (8 generated)
Description was changed from ========== Fix mjsunit oddities (new try). 1) assertInstanceOf(o, Foo, Bar) used to produce this error message: Failure: expected <o> is not an instance of <Foo> but of < Bar>> found <undefined> Fixed: Failure: expected <o> is not an instance of <Foo> but of <Bar> 2) assertDoesNotThrow("throw 1") used to produce this error message: Failure: expected <threw an exception: > found <1> Fixed: threw an exception: 1 3) assertDoesNotThrow("...", SomeError) was not doing what you'd think it does, so removed the last parameter. BUG= ========== to ========== Fix mjsunit oddities (new try). 1) assertInstanceOf(o, Foo, Bar) used to produce this error message: Failure: <o> is not an instance of <Foo> but of < Bar>> found <undefined> Fixed: Failure: expected <o> is not an instance of <Foo> but of <Bar> 2) assertDoesNotThrow("throw 1") used to produce this error message: Failure: expected <threw an exception: > found <1> Fixed: threw an exception: 1 3) assertDoesNotThrow("...", SomeError) was not doing what you'd think it does, so removed the last parameter. BUG= ==========
Description was changed from ========== Fix mjsunit oddities (new try). 1) assertInstanceOf(o, Foo, Bar) used to produce this error message: Failure: <o> is not an instance of <Foo> but of < Bar>> found <undefined> Fixed: Failure: expected <o> is not an instance of <Foo> but of <Bar> 2) assertDoesNotThrow("throw 1") used to produce this error message: Failure: expected <threw an exception: > found <1> Fixed: threw an exception: 1 3) assertDoesNotThrow("...", SomeError) was not doing what you'd think it does, so removed the last parameter. BUG= ========== to ========== Fix mjsunit oddities (new try). 1) assertInstanceOf(o, Foo, Bar) used to produce this error message: Failure: exptected <o> is not an instance of <Foo> but of < Bar>> found <undefined> Fixed: Failure: <o> is not an instance of <Foo> but of <Bar> 2) assertDoesNotThrow("throw 1") used to produce this error message: Failure: expected <threw an exception: > found <1> Fixed: threw an exception: 1 3) assertDoesNotThrow("...", SomeError) was not doing what you'd think it does, so removed the last parameter. BUG= ==========
Description was changed from ========== Fix mjsunit oddities (new try). 1) assertInstanceOf(o, Foo, Bar) used to produce this error message: Failure: exptected <o> is not an instance of <Foo> but of < Bar>> found <undefined> Fixed: Failure: <o> is not an instance of <Foo> but of <Bar> 2) assertDoesNotThrow("throw 1") used to produce this error message: Failure: expected <threw an exception: > found <1> Fixed: threw an exception: 1 3) assertDoesNotThrow("...", SomeError) was not doing what you'd think it does, so removed the last parameter. BUG= ========== to ========== Fix mjsunit oddities (new try). 1) assertInstanceOf(o, Foo, Bar) used to produce this error message: Failure: expected <o> is not an instance of <Foo> but of < Bar>> found <undefined> Fixed: Failure: <o> is not an instance of <Foo> but of <Bar> 2) assertDoesNotThrow("throw 1") used to produce this error message: Failure: expected <threw an exception: > found <1> Fixed: threw an exception: 1 3) assertDoesNotThrow("...", SomeError) was not doing what you'd think it does, so removed the last parameter. BUG= ==========
Description was changed from ========== Fix mjsunit oddities (new try). 1) assertInstanceOf(o, Foo, Bar) used to produce this error message: Failure: expected <o> is not an instance of <Foo> but of < Bar>> found <undefined> Fixed: Failure: <o> is not an instance of <Foo> but of <Bar> 2) assertDoesNotThrow("throw 1") used to produce this error message: Failure: expected <threw an exception: > found <1> Fixed: threw an exception: 1 3) assertDoesNotThrow("...", SomeError) was not doing what you'd think it does, so removed the last parameter. BUG= ========== to ========== Fix mjsunit oddities (new try). 1) assertInstanceOf(o, Foo, Bar) used to produce this error message: Failure: expected <o> is not an instance of <Foo> but of < Bar>> found <undefined> Fixed: Failure: <o> is not an instance of <Foo> but of <Bar> 2) assertDoesNotThrow("throw 1") used to produce this error message: Failure: expected <threw an exception: > found <1> Fixed: Failure: threw an exception: 1 3) assertDoesNotThrow("...", SomeError) was not doing what you'd think it does, so removed the last parameter. BUG= ==========
verwaest@chromium.org changed reviewers: + verwaest@chromium.org
lgtm
The CQ bit was checked by marja@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix mjsunit oddities (new try). 1) assertInstanceOf(o, Foo, Bar) used to produce this error message: Failure: expected <o> is not an instance of <Foo> but of < Bar>> found <undefined> Fixed: Failure: <o> is not an instance of <Foo> but of <Bar> 2) assertDoesNotThrow("throw 1") used to produce this error message: Failure: expected <threw an exception: > found <1> Fixed: Failure: threw an exception: 1 3) assertDoesNotThrow("...", SomeError) was not doing what you'd think it does, so removed the last parameter. BUG= ========== to ========== Fix mjsunit oddities (new try). 1) assertInstanceOf(o, Foo, Bar) used to produce this error message: Failure: expected <o> is not an instance of <Foo> but of < Bar>> found <undefined> Fixed: Failure: <o> is not an instance of <Foo> but of <Bar> 2) assertDoesNotThrow("throw 1") used to produce this error message: Failure: expected <threw an exception: > found <1> Fixed: Failure: threw an exception: 1 3) assertDoesNotThrow("...", SomeError) was not doing what you'd think it does, so removed the last parameter. BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix mjsunit oddities (new try). 1) assertInstanceOf(o, Foo, Bar) used to produce this error message: Failure: expected <o> is not an instance of <Foo> but of < Bar>> found <undefined> Fixed: Failure: <o> is not an instance of <Foo> but of <Bar> 2) assertDoesNotThrow("throw 1") used to produce this error message: Failure: expected <threw an exception: > found <1> Fixed: Failure: threw an exception: 1 3) assertDoesNotThrow("...", SomeError) was not doing what you'd think it does, so removed the last parameter. BUG= ========== to ========== Fix mjsunit oddities (new try). 1) assertInstanceOf(o, Foo, Bar) used to produce this error message: Failure: expected <o> is not an instance of <Foo> but of < Bar>> found <undefined> Fixed: Failure: <o> is not an instance of <Foo> but of <Bar> 2) assertDoesNotThrow("throw 1") used to produce this error message: Failure: expected <threw an exception: > found <1> Fixed: Failure: threw an exception: 1 3) assertDoesNotThrow("...", SomeError) was not doing what you'd think it does, so removed the last parameter. BUG= Committed: https://crrev.com/e27ef0a60392ff2180b528e8d34d3bfb9f079319 Cr-Commit-Position: refs/heads/master@{#40347} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e27ef0a60392ff2180b528e8d34d3bfb9f079319 Cr-Commit-Position: refs/heads/master@{#40347} |