Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2424743003: Fix mjsunit oddities (new try). (Closed)

Created:
4 years, 2 months ago by marja
Modified:
4 years, 2 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix mjsunit oddities (new try). 1) assertInstanceOf(o, Foo, Bar) used to produce this error message: Failure: expected <o> is not an instance of <Foo> but of < Bar>> found <undefined> Fixed: Failure: <o> is not an instance of <Foo> but of <Bar> 2) assertDoesNotThrow("throw 1") used to produce this error message: Failure: expected <threw an exception: > found <1> Fixed: Failure: threw an exception: 1 3) assertDoesNotThrow("...", SomeError) was not doing what you'd think it does, so removed the last parameter. BUG= Committed: https://crrev.com/e27ef0a60392ff2180b528e8d34d3bfb9f079319 Cr-Commit-Position: refs/heads/master@{#40347}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M test/mjsunit/invalid-lhs.js View 2 chunks +5 lines, -5 lines 0 comments Download
M test/mjsunit/mjsunit.js View 7 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Toon Verwaest
lgtm
4 years, 2 months ago (2016-10-17 09:03:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424743003/1
4 years, 2 months ago (2016-10-17 09:03:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 09:34:27 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 09:35:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e27ef0a60392ff2180b528e8d34d3bfb9f079319
Cr-Commit-Position: refs/heads/master@{#40347}

Powered by Google App Engine
This is Rietveld 408576698