Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2424693003: Take the scope info of the direct outer scope as outer scope info (Closed)

Created:
4 years, 2 months ago by Toon Verwaest
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Take the scope info of the direct outer scope as outer scope info BUG=v8:5209 Committed: https://crrev.com/fbef7e148507f418a92cb59117e068b7676fa2db Cr-Commit-Position: refs/heads/master@{#40356}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M src/ast/scopes.cc View 1 chunk +2 lines, -5 lines 2 comments Download

Messages

Total messages: 14 (7 generated)
Toon Verwaest
ptal
4 years, 2 months ago (2016-10-17 09:13:37 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/2424693003/diff/1/src/ast/scopes.cc File src/ast/scopes.cc (right): https://codereview.chromium.org/2424693003/diff/1/src/ast/scopes.cc#newcode1090 src/ast/scopes.cc:1090: if (outer_scope_ != nullptr) outer_scope = outer_scope_->scope_info_; DCHECK that ...
4 years, 2 months ago (2016-10-17 09:55:51 UTC) #5
Toon Verwaest
https://codereview.chromium.org/2424693003/diff/1/src/ast/scopes.cc File src/ast/scopes.cc (right): https://codereview.chromium.org/2424693003/diff/1/src/ast/scopes.cc#newcode1090 src/ast/scopes.cc:1090: if (outer_scope_ != nullptr) outer_scope = outer_scope_->scope_info_; On 2016/10/17 ...
4 years, 2 months ago (2016-10-17 10:34:37 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-17 11:21:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424693003/1
4 years, 2 months ago (2016-10-17 11:22:34 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 11:25:34 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 11:25:49 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbef7e148507f418a92cb59117e068b7676fa2db
Cr-Commit-Position: refs/heads/master@{#40356}

Powered by Google App Engine
This is Rietveld 408576698