Take the scope info of the direct outer scope as outer scope info

Take the scope info of the direct outer scope as outer scope info

BUG=v8:5209
Committed: https://crrev.com/fbef7e148507f418a92cb59117e068b7676fa2db
Cr-Commit-Position: refs/heads/master@{#40356}

[Toon Verwaest, 2016-10-17 09:13:36]

verwaest@chromium.org changed reviewers:
+ jochen@chromium.org

[Toon Verwaest, 2016-10-17 09:13:37]

ptal

[Toon Verwaest, 2016-10-17 09:54:23]

The CQ bit was checked by verwaest@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 09:54:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-10-17 09:55:51]

https://codereview.chromium.org/2424693003/diff/1/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2424693003/diff/1/src/ast/scopes.cc#newcode1090
src/ast/scopes.cc:1090: if (outer_scope_ != nullptr) outer_scope =
outer_scope_->scope_info_;
DCHECK that scope_info_ is not null?

[commit-bot: I haz the power, 2016-10-17 10:23:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 10:23:08]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-10-17 10:34:37]

https://codereview.chromium.org/2424693003/diff/1/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2424693003/diff/1/src/ast/scopes.cc#newcode1090
src/ast/scopes.cc:1090: if (outer_scope_ != nullptr) outer_scope =
outer_scope_->scope_info_;
On 2016/10/17 09:55:51, jochen wrote:
> DCHECK that scope_info_ is not null?

That scope info isn't guaranteed to be non-null. We can have a module scope with
an outer script scope, both of which were freshly created for this compile.

[jochen (gone - plz use gerrit), 2016-10-17 11:21:58]

lgtm

[Toon Verwaest, 2016-10-17 11:22:29]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2016-10-17 11:22:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 11:25:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-17 11:25:49]

Description was changed from

==========
Take the scope info of the direct outer scope as outer scope info

BUG=v8:5209
==========

to

==========
Take the scope info of the direct outer scope as outer scope info

BUG=v8:5209

Committed: https://crrev.com/fbef7e148507f418a92cb59117e068b7676fa2db
Cr-Commit-Position: refs/heads/master@{#40356}
==========

[commit-bot: I haz the power, 2016-10-17 11:25:49]

Patchset 1 (id:??) landed as
https://crrev.com/fbef7e148507f418a92cb59117e068b7676fa2db
Cr-Commit-Position: refs/heads/master@{#40356}