Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: third_party/WebKit/LayoutTests/custom-elements/spec/define-builtin-element.html

Issue 2424693002: Custom Elements: Complete HTMLConstructor Algorithm (Closed)
Patch Set: Redefinition guard Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/custom-elements/spec/define-builtin-element-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/custom-elements/spec/define-builtin-element.html
diff --git a/third_party/WebKit/LayoutTests/custom-elements/spec/define-builtin-element.html b/third_party/WebKit/LayoutTests/custom-elements/spec/define-builtin-element.html
index 3635a8bc1c31fa803b257d14903259a66fd3fdd6..02567ba6e050e62a585788e33721b34793729e45 100644
--- a/third_party/WebKit/LayoutTests/custom-elements/spec/define-builtin-element.html
+++ b/third_party/WebKit/LayoutTests/custom-elements/spec/define-builtin-element.html
@@ -24,7 +24,7 @@ test_with_window((w) => {
}, `having valid custon element name element interface (${val}) ` +
'for extends should throw a NotSupportedError')
});
-}, 'Element interface for extends is not valid custom element name');
+}, 'Element interface for extends is not valid custom element name should throw error');
test_with_window((w) => {
class A extends w.HTMLButtonElement {}
@@ -43,12 +43,12 @@ test_with_window((w) => {
}, `having element interface for extends (${val}) undefined in specs` +
' should throw a NotSupportedError');
});
-}, 'Element interface for extends defined in specification');
+}, 'Element interface for extends not defined in specification should throw error');
test_with_window((w) => {
- class A extends w.HTMLButtonElement {}
- w.customElements.define('defined-name', A, { extends: 'button' });
- assert_equals(new A().localName, 'button',
+ class A extends w.HTMLDivElement {}
+ w.customElements.define('defined-name', A, { extends: 'div' });
+ assert_equals(new A().localName, 'div',
'localName should be element interface for extends');
assert_not_equals(new A().localName, 'defined-name',
'localName should not be defined-name');
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/custom-elements/spec/define-builtin-element-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698