Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 2424643002: [ios] Removed remaining code for URL spoofing interstitials. (Closed)

Created:
4 years, 2 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 1 month ago
Reviewers:
estark
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed remaining code for URL spoofing interstitials. Chrome for iOS does not present URL spoofing error after switching to WKWebView. BUG=579697 Committed: https://crrev.com/209dfc6b2338d707212ff264b662e90c91227051 Cr-Commit-Position: refs/heads/master@{#427287}

Patch Set 1 #

Patch Set 2 : Self review #

Patch Set 3 : Removed browser_constants.h include #

Total comments: 2

Patch Set 4 : Removed reference to Safe Browsing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -64 lines) Patch
M ios/chrome/app/strings/ios_strings.grd View 1 2 3 1 chunk +0 lines, -11 lines 0 comments Download
M ios/chrome/browser/ssl/ios_ssl_blocking_page.mm View 1 2 2 chunks +0 lines, -23 lines 0 comments Download
M ios/public/provider/chrome/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D ios/public/provider/chrome/browser/browser_constants.h View 1 chunk +0 lines, -17 lines 0 comments Download
D ios/public/provider/chrome/browser/browser_constants.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
elawrence
Thanks for cleaning these up! https://codereview.chromium.org/2424643002/diff/40001/ios/chrome/app/strings/ios_strings.grd File ios/chrome/app/strings/ios_strings.grd (right): https://codereview.chromium.org/2424643002/diff/40001/ios/chrome/app/strings/ios_strings.grd#newcode236 ios/chrome/app/strings/ios_strings.grd:236: <!-- Safe Browsing --> ...
4 years, 2 months ago (2016-10-16 03:43:58 UTC) #9
Eugene But (OOO till 7-30)
https://codereview.chromium.org/2424643002/diff/40001/ios/chrome/app/strings/ios_strings.grd File ios/chrome/app/strings/ios_strings.grd (right): https://codereview.chromium.org/2424643002/diff/40001/ios/chrome/app/strings/ios_strings.grd#newcode236 ios/chrome/app/strings/ios_strings.grd:236: <!-- Safe Browsing --> On 2016/10/16 03:43:58, elawrence wrote: ...
4 years, 1 month ago (2016-10-24 15:57:58 UTC) #14
Eugene But (OOO till 7-30)
4 years, 1 month ago (2016-10-24 15:59:01 UTC) #16
estark
lgtm
4 years, 1 month ago (2016-10-25 03:44:00 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424643002/60001
4 years, 1 month ago (2016-10-25 05:33:29 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-10-25 06:35:28 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 06:36:56 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/209dfc6b2338d707212ff264b662e90c91227051
Cr-Commit-Position: refs/heads/master@{#427287}

Powered by Google App Engine
This is Rietveld 408576698