Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: src/isolate.cc

Issue 2424623002: [wasm] Use a Managed<WasmModule> to hold metadata about modules. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 792706dc71c54dc2de0bd5f992044004d26f2b46..a1ba98e8e4eb0b5f37de11bebf5e59487cfac091 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -509,7 +509,7 @@ Handle<Object> Isolate::CaptureSimpleStackTrace(Handle<JSReceiver> error_object,
case StackFrame::WASM: {
WasmFrame* wasm_frame = WasmFrame::cast(frame);
- Handle<Object> wasm_object(wasm_frame->wasm_obj(), this);
+ Handle<Object> wasm_module(wasm_frame->wasm_obj(), this);
Mircea Trofin 2016/10/15 17:38:40 Could the renames be a separate change?
const int wasm_function_index = wasm_frame->function_index();
Code* code = wasm_frame->unchecked_code();
Handle<AbstractCode> abstract_code(AbstractCode::cast(code), this);
@@ -518,14 +518,14 @@ Handle<Object> Isolate::CaptureSimpleStackTrace(Handle<JSReceiver> error_object,
// TODO(wasm): The wasm object returned by the WasmFrame should always
// be a wasm object.
- DCHECK(wasm::IsWasmObject(*wasm_object) ||
- wasm_object->IsUndefined(this));
+ DCHECK(wasm::IsWasmModule(*wasm_module) ||
+ wasm_module->IsUndefined(this));
- int flags = wasm::WasmIsAsmJs(*wasm_object, this)
+ int flags = wasm::WasmIsAsmJs(*wasm_module, this)
? FrameArray::kIsAsmJsWasmFrame
: FrameArray::kIsWasmFrame;
- elements = FrameArray::AppendWasmFrame(elements, wasm_object,
+ elements = FrameArray::AppendWasmFrame(elements, wasm_module,
wasm_function_index,
abstract_code, offset, flags);
} break;

Powered by Google App Engine
This is Rietveld 408576698