[wasm] Use a Managed<WasmModule> to hold metadata about modules.

test/cctest/wasm/test-run-wasm-module.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdlib.h>
 #include <string.h>
 
 #include "src/wasm/module-decoder.h"
 #include "src/wasm/wasm-macro-gen.h"
 #include "src/wasm/wasm-module-builder.h"
@@ skipping 179 matching lines @@
   Isolate* isolate = CcTest::InitIsolateOnce();
   ErrorThrower thrower(isolate, "");
   uint8_t* bytes = nullptr;
   size_t bytes_size = 0;
   v8::WasmCompiledModule::SerializedModule data;
   {
     HandleScope scope(isolate);
     testing::SetupIsolateForWasmModule(isolate);
 
     ModuleResult decoding_result = DecodeWasmModule(
-        isolate, &zone, buffer.begin(), buffer.end(), false, kWasmOrigin);
-    std::unique_ptr<const WasmModule> module(decoding_result.val);
-    CHECK(!decoding_result.failed());
-
+        isolate, buffer.begin(), buffer.end(), false, kWasmOrigin);
+    if (decoding_result.failed()) {
+      delete decoding_result.val;
+      CHECK(false);
+    }
+    WasmModule* module = const_cast<WasmModule*>(decoding_result.val);
+    Handle<WasmModuleWrapper> module_wrapper =
+        WasmModuleWrapper::New(isolate, module);
     MaybeHandle<WasmCompiledModule> compiled_module =
-        module->CompileFunctions(isolate, &thrower);
+        module->CompileFunctions(isolate, module_wrapper, &thrower);
     CHECK(!compiled_module.is_null());
-    Handle<JSObject> module_obj = CreateCompiledModuleObject(
+    Handle<JSObject> module_obj = CreateWasmModuleObject(
         isolate, compiled_module.ToHandleChecked(), ModuleOrigin::kWasmOrigin);
     v8::Local<v8::Object> v8_module_obj = v8::Utils::ToLocal(module_obj);
     CHECK(v8_module_obj->IsWebAssemblyCompiledModule());
 
     v8::Local<v8::WasmCompiledModule> v8_compiled_module =
         v8_module_obj.As<v8::WasmCompiledModule>();
     v8::Local<v8::String> uncompiled_bytes =
         v8_compiled_module->GetWasmWireBytes();
     bytes_size = static_cast<size_t>(uncompiled_bytes->Length());
     bytes = zone.NewArray<uint8_t>(uncompiled_bytes->Length());
@@ skipping 149 matching lines @@
                  WASM_I32V(121)};
   f->EmitCode(code, sizeof(code));
   ZoneBuffer buffer(&zone);
   builder->WriteTo(buffer);
 
   HandleScope scope(isolate);
   testing::SetupIsolateForWasmModule(isolate);
   ErrorThrower thrower(isolate, "Test");
   const Handle<JSObject> instance =
       testing::CompileInstantiateWasmModuleForTesting(
-          isolate, &thrower, &zone, buffer.begin(), buffer.end(),
+          isolate, &thrower, buffer.begin(), buffer.end(),
           ModuleOrigin::kWasmOrigin);
   CHECK(!instance.is_null());
 
   MaybeHandle<JSArrayBuffer> maybe_memory =
       GetInstanceMemory(isolate, instance);
   Handle<JSArrayBuffer> memory = maybe_memory.ToHandleChecked();
   int32_t* memory_array = reinterpret_cast<int32_t*>(memory->backing_store());
 
   InterruptThread thread(isolate, memory_array);
   thread.Start();
@@ skipping 53 matching lines @@
       WASM_LOAD_MEM(MachineType::Int32(), WASM_I32V(index))};
   f->EmitCode(code, sizeof(code));
 
   HandleScope scope(isolate);
   ZoneBuffer buffer(&zone);
   builder->WriteTo(buffer);
   testing::SetupIsolateForWasmModule(isolate);
 
   ErrorThrower thrower(isolate, "Test");
   Handle<JSObject> instance = testing::CompileInstantiateWasmModuleForTesting(
-      isolate, &thrower, &zone, buffer.begin(), buffer.end(),
+      isolate, &thrower, buffer.begin(), buffer.end(),
       ModuleOrigin::kWasmOrigin);
   CHECK(!instance.is_null());
 
   // Initial memory size is 16 pages, should trap till index > MemSize on
   // consecutive GrowMem calls
   for (uint32_t i = 1; i < 5; i++) {
     Handle<Object> params[1] = {Handle<Object>(Smi::FromInt(i), isolate)};
     v8::TryCatch try_catch(reinterpret_cast<v8::Isolate*>(isolate));
     testing::RunWasmModuleForTesting(isolate, instance, 1, params,
                                      ModuleOrigin::kWasmOrigin);
@@ skipping 24 matching lines @@
       WASM_LOAD_MEM(MachineType::Int32(), WASM_GET_LOCAL(0))};
   f->EmitCode(code, sizeof(code));
 
   HandleScope scope(isolate);
   ZoneBuffer buffer(&zone);
   builder->WriteTo(buffer);
   testing::SetupIsolateForWasmModule(isolate);
 
   ErrorThrower thrower(isolate, "Test");
   Handle<JSObject> instance = testing::CompileInstantiateWasmModuleForTesting(
-      isolate, &thrower, &zone, buffer.begin(), buffer.end(),
+      isolate, &thrower, buffer.begin(), buffer.end(),
       ModuleOrigin::kWasmOrigin);
 
   CHECK(!instance.is_null());
 
   // Initial memory size is 16 pages, should trap till index > MemSize on
   // consecutive GrowMem calls
   for (int i = 1; i < 5; i++) {
     Handle<Object> params[1] = {
         Handle<Object>(Smi::FromInt((16 + i) * kPageSize - 3), isolate)};
     v8::TryCatch try_catch(reinterpret_cast<v8::Isolate*>(isolate));
@@ skipping 103 matching lines @@
 
 TEST(Run_WasmModule_Global_f32) {
   RunWasmModuleGlobalInitTest<float>(kAstF32, -983.9f);
   RunWasmModuleGlobalInitTest<float>(kAstF32, 1122.99f);
 }
 
 TEST(Run_WasmModule_Global_f64) {
   RunWasmModuleGlobalInitTest<double>(kAstF64, -833.9);
   RunWasmModuleGlobalInitTest<double>(kAstF64, 86374.25);
 }