Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2424613002: Remove usage of FOR_EACH_OBSERVER macro in services/ (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in services/ Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/e9f4516076a6e3a3b4b8043347e613f5cc59165e Cr-Commit-Position: refs/heads/master@{#425615}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -133 lines) Patch
M services/navigation/public/cpp/view.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M services/ui/public/cpp/input_devices/input_device_client.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M services/ui/public/cpp/window.cc View 13 chunks +42 lines, -40 lines 0 comments Download
M services/ui/public/cpp/window_tree_client.cc View 7 chunks +20 lines, -20 lines 0 comments Download
M services/ui/ws/animation_runner.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M services/ui/ws/focus_controller.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M services/ui/ws/server_window.cc View 16 chunks +38 lines, -39 lines 0 comments Download
M services/ui/ws/user_id_tracker.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M services/ui/ws/window_manager_window_tree_factory_set.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Eric Willigers
4 years, 2 months ago (2016-10-16 20:31:55 UTC) #6
Ben Goodger (Google)
rs lgtm
4 years, 2 months ago (2016-10-17 02:35:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424613002/1
4 years, 2 months ago (2016-10-17 03:12:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 04:29:53 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 04:32:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9f4516076a6e3a3b4b8043347e613f5cc59165e
Cr-Commit-Position: refs/heads/master@{#425615}

Powered by Google App Engine
This is Rietveld 408576698