Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2424603002: Remove usage of FOR_EACH_OBSERVER macro in ui/message_center (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
dewittj
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in ui/message_center Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/dfd9e46ec6757c9285ad9d7365651b461e5a6b19 Cr-Commit-Position: refs/heads/master@{#425749}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -55 lines) Patch
M ui/message_center/message_center_impl.cc View 18 chunks +44 lines, -53 lines 0 comments Download
M ui/message_center/notification_blocker.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Eric Willigers
4 years, 2 months ago (2016-10-15 14:03:50 UTC) #4
dewittj
lgtm
4 years, 2 months ago (2016-10-17 16:04:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424603002/1
4 years, 2 months ago (2016-10-17 18:45:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 19:38:46 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 19:42:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfd9e46ec6757c9285ad9d7365651b461e5a6b19
Cr-Commit-Position: refs/heads/master@{#425749}

Powered by Google App Engine
This is Rietveld 408576698