Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 24246013: Remove redundantly setting WTF_VECTOR_INITIAL_SIZE in build/common.gypi (Closed)

Created:
7 years, 3 months ago by lgombos
Modified:
7 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

WTF_VECTOR_INITIAL_SIZE properly defaults to 4 in wtf/Vector.h. No need to overrule the WTF_VECTOR_INITIAL_SIZE macro in the global gyp configuration file any more. BUG=285442 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224573

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
lgombos
This seems a desired cleanup after https://codereview.chromium.org/23453040.
7 years, 3 months ago (2013-09-20 18:03:59 UTC) #1
abarth-chromium
lgtm
7 years, 3 months ago (2013-09-20 18:05:25 UTC) #2
Chris Evans
On 2013/09/20 18:03:59, lgombos wrote: > This seems a desired cleanup after https://codereview.chromium.org/23453040. LGTM. I ...
7 years, 3 months ago (2013-09-20 18:06:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/24246013/1
7 years, 3 months ago (2013-09-20 18:19:18 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=200559
7 years, 3 months ago (2013-09-21 01:57:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/24246013/1
7 years, 3 months ago (2013-09-21 02:00:03 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-21 06:08:14 UTC) #7
Message was sent while issue was closed.
Change committed as 224573

Powered by Google App Engine
This is Rietveld 408576698