Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 24246009: Begin renaming the WebKit namespace to blink (Closed)

Created:
7 years, 3 months ago by abarth-chromium
Modified:
7 years, 1 month ago
Reviewers:
jamesr
CC:
chromium-reviews, darin (slow to review), eseidel
Visibility:
Public.

Description

Begin renaming the WebKit namespace to blink This CL introduces a global preprocessor macro to rename WebKit to blink. After this CL lands, we'll update the code to use the blink namespace incrementally. Once we've converted all the code, we'll remove the preprocessor macro. R=jamesr@chromium.org, jamesr BUG=295096 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233284

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/common.gypi View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
abarth-chromium
7 years, 3 months ago (2013-09-19 21:35:06 UTC) #1
abarth-chromium
This CL isn't quite ready to land. We'll need to update the Clang plugin first ...
7 years, 3 months ago (2013-09-19 21:36:16 UTC) #2
jamesr
As expected this breaks the clang bots, but lgtm once that's resolved. https://codereview.chromium.org/24246009/diff/1/build/common.gypi File build/common.gypi ...
7 years, 3 months ago (2013-09-19 21:50:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/24246009/24001
7 years, 1 month ago (2013-11-05 21:47:28 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=185508
7 years, 1 month ago (2013-11-05 23:48:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/24246009/24001
7 years, 1 month ago (2013-11-06 00:53:28 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94434
7 years, 1 month ago (2013-11-06 04:44:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/24246009/24001
7 years, 1 month ago (2013-11-06 04:49:41 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94653
7 years, 1 month ago (2013-11-06 09:23:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/24246009/24001
7 years, 1 month ago (2013-11-06 15:36:07 UTC) #10
abarth-chromium
7 years, 1 month ago (2013-11-06 17:32:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 manually as r233284 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698