sdk/lib/_internal/pub/test/update/git/update_to_nonexistent_pubspec_test.dart - Issue 24246002: Lazily throw pubspec parsing exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/test/update/git/update_to_nonexistent_pubspec_test.dart

Issue 24246002: Lazily throw pubspec parsing exceptions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/test/update/git/update_to_incompatible_pubspec_test.dart ('k') | sdk/lib/_internal/pub/test/validator/pubspec_field_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/test/update/git/update_to_nonexistent_pubspec_test.dart

diff --git a/sdk/lib/_internal/pub/test/update/git/update_to_nonexistent_pubspec_test.dart b/sdk/lib/_internal/pub/test/update/git/update_to_nonexistent_pubspec_test.dart

index 8cb8971748ee8aaac72c3b63ed5d3964e53fdec6..6a9213c8348e278da37588bf31070f791467726e 100644

--- a/sdk/lib/_internal/pub/test/update/git/update_to_nonexistent_pubspec_test.dart

+++ b/sdk/lib/_internal/pub/test/update/git/update_to_nonexistent_pubspec_test.dart

@@ -31,7 +31,8 @@ main() {

repo.runGit(['rm', 'pubspec.yaml']);

repo.runGit(['commit', '-m', 'delete']);

- pubUpdate(error: 'Package "foo" doesn\'t have a pubspec.yaml file.');

+ pubUpdate(error: new RegExp(r'Could not find a file named "pubspec.yaml" '

+ r'in "[^\n]*"\.'));

d.dir(packagesPath, [

d.dir('foo', [