sdk/lib/_internal/pub/test/serve/fails_to_load_a_pubspec_with_reserved_transformer_config_test.dart - Issue 24246002: Lazily throw pubspec parsing exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/test/serve/fails_to_load_a_pubspec_with_reserved_transformer_config_test.dart

Issue 24246002: Lazily throw pubspec parsing exceptions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/test/pubspec_test.dart ('k') | sdk/lib/_internal/pub/test/serve/fails_to_load_a_transform_from_a_non_dependency_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/test/serve/fails_to_load_a_pubspec_with_reserved_transformer_config_test.dart

diff --git a/sdk/lib/_internal/pub/test/serve/fails_to_load_a_pubspec_with_reserved_transformer_config_test.dart b/sdk/lib/_internal/pub/test/serve/fails_to_load_a_pubspec_with_reserved_transformer_config_test.dart

index 5ba03d8353992149139f163dcd1ecf6cc99b0c02..06762d8dcbd95b531ef37e72c5b3767a14f8f3d5 100644

--- a/sdk/lib/_internal/pub/test/serve/fails_to_load_a_pubspec_with_reserved_transformer_config_test.dart

+++ b/sdk/lib/_internal/pub/test/serve/fails_to_load_a_pubspec_with_reserved_transformer_config_test.dart

@@ -27,10 +27,11 @@ main() {

createLockFile('myapp', pkg: ['barback']);

var pub = startPub(args: ['serve', '--port=0']);

- expect(pub.nextErrLine(), completion(startsWith('Could not parse ')));

- expect(pub.nextErrLine(), completion(equals('Configuration for '

- 'transformer myapp/src/transformer may not include reserved key '

- '"include".')));

+ expect(pub.nextErrLine(), completion(equals('Error in pubspec for package '

+ '"myapp" loaded from pubspec.yaml:')));

+ expect(pub.nextErrLine(), completion(equals('Invalid transformer '

+ 'identifier for "transformers.myapp/src/transformer": Transformer '

+ 'configuration may not include reserved key "include".')));

pub.shouldExit(1);

});

}