Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: sdk/lib/_internal/pub/test/pub_install_and_update_test.dart

Issue 24246002: Lazily throw pubspec parsing exceptions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/pub_install_and_update_test.dart
diff --git a/sdk/lib/_internal/pub/test/pub_install_and_update_test.dart b/sdk/lib/_internal/pub/test/pub_install_and_update_test.dart
index 06da50a8d96825b25c3aaa5c8484bbe12fb000b2..f1bbf152d762b94e420711cde1e0de40a63a34bb 100644
--- a/sdk/lib/_internal/pub/test/pub_install_and_update_test.dart
+++ b/sdk/lib/_internal/pub/test/pub_install_and_update_test.dart
@@ -18,8 +18,8 @@ main() {
d.dir(appPath, []).create();
pubCommand(command,
- error: new RegExp(r'^Could not find a file named "pubspec.yaml" '
- r'in the directory .*\.$'));
+ error: new RegExp(r'Could not find a file named "pubspec.yaml" '
+ r'in "[^\n]*"\.'));
});
integration('a pubspec with a "name" key', () {
@@ -27,9 +27,8 @@ main() {
d.pubspec({"dependencies": {"foo": null}})
]).create();
- pubCommand(command, error:
- 'pubspec.yaml is missing the required "name" field '
- '(e.g. "name: myapp").');
+ pubCommand(command, error: new RegExp(r'Missing the required "name" '
+ r'field\.'));
});
});
@@ -121,8 +120,8 @@ main() {
})
]).create();
- pubCommand(command,
- error: new RegExp("Package 'myapp' cannot depend on itself."));
+ pubCommand(command, error: new RegExp(r'"dependencies.myapp": Package '
+ r'may not list itself as a dependency\.'));
});
integration('does not allow a dev dependency on itself', () {
@@ -135,8 +134,8 @@ main() {
})
]).create();
- pubCommand(command,
- error: new RegExp("Package 'myapp' cannot depend on itself."));
+ pubCommand(command, error: new RegExp(r'"dev_dependencies.myapp": '
+ r'Package may not list itself as a dependency\.'));
});
});
}
« no previous file with comments | « sdk/lib/_internal/pub/test/install/path/no_pubspec_test.dart ('k') | sdk/lib/_internal/pub/test/pubspec_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698