sdk/lib/_internal/pub/test/install/git/require_pubspec_name_test.dart - Issue 24246002: Lazily throw pubspec parsing exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/test/install/git/require_pubspec_name_test.dart

Issue 24246002: Lazily throw pubspec parsing exceptions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/test/install/git/dependency_name_match_pubspec_test.dart ('k') | sdk/lib/_internal/pub/test/install/git/require_pubspec_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/test/install/git/require_pubspec_name_test.dart

diff --git a/sdk/lib/_internal/pub/test/install/git/require_pubspec_name_test.dart b/sdk/lib/_internal/pub/test/install/git/require_pubspec_name_test.dart

index 6baa826ec5e30724ba6a6be643991185b0fe9fae..92d35f223d403a7d2326f18b16b35b5e26d55d9f 100644

--- a/sdk/lib/_internal/pub/test/install/git/require_pubspec_name_test.dart

+++ b/sdk/lib/_internal/pub/test/install/git/require_pubspec_name_test.dart

@@ -20,10 +20,7 @@ main() {

d.appDir({"foo": {"git": "../foo.git"}}).create();

- // TODO(nweiz): clean up this RegExp when either issue 4706 or 4707 is

- // fixed.

- pubInstall(error:

- 'Package "foo"\'s pubspec.yaml file is '

- 'missing the required "name" field (e.g. "name: foo").');

+ pubInstall(error: new RegExp(r'Missing the required "name" field \(e\.g\. '

+ r'"name: foo"\)\.'));

});

}