Lazily throw pubspec parsing exceptions.

sdk/lib/_internal/pub/test/validator/pubspec_field_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:scheduled_test/scheduled_test.dart';
 
 import '../../lib/src/entrypoint.dart';
 import '../../lib/src/validator.dart';
 import '../../lib/src/validator/pubspec_field.dart';
 import '../descriptor.dart' as d;
@@ skipping 10 matching lines @@
     setUp(d.validPackage.create);
 
     integration('looks normal', () => expectNoValidationError(pubspecField));
 
     integration('has "authors" instead of "author"', () {
       var pkg = packageMap("test_pkg", "1.0.0");
       pkg["authors"] = [pkg.remove("author")];
       d.dir(appPath, [d.pubspec(pkg)]).create();
       expectNoValidationError(pubspecField);
     });
+
+    integration('has an HTTPS homepage URL', () {
+      var pkg = packageMap("test_pkg", "1.0.0");
+      pkg["homepage"] = "https://pub.dartlang.org";
+      d.dir(appPath, [d.pubspec(pkg)]).create();
+
+      expectNoValidationError(pubspecField);
+    });
+
+    integration('has an HTTPS documentation URL', () {
+      var pkg = packageMap("test_pkg", "1.0.0");
+      pkg["documentation"] = "https://pub.dartlang.org";
+      d.dir(appPath, [d.pubspec(pkg)]).create();
+
+      expectNoValidationError(pubspecField);
+    });
   });
 
   group('should consider a package invalid if it', () {
     setUp(d.validPackage.create);
 
     integration('is missing the "homepage" field', () {
       var pkg = packageMap("test_pkg", "1.0.0");
       pkg.remove("homepage");
       d.dir(appPath, [d.pubspec(pkg)]).create();
 
       expectValidationError(pubspecField);
     });
 
     integration('is missing the "description" field', () {
       var pkg = packageMap("test_pkg", "1.0.0");
       pkg.remove("description");
       d.dir(appPath, [d.pubspec(pkg)]).create();
 
       expectValidationError(pubspecField);
     });
 
     integration('is missing the "author" field', () {
       var pkg = packageMap("test_pkg", "1.0.0");
       pkg.remove("author");
       d.dir(appPath, [d.pubspec(pkg)]).create();
 
       expectValidationError(pubspecField);
     });
 
+    integration('has a non-string "homepage" field', () {
+      var pkg = packageMap("test_pkg", "1.0.0");
+      pkg["homepage"] = 12;
+      d.dir(appPath, [d.pubspec(pkg)]).create();
+
+      expectValidationError(pubspecField);
+    });
+
+    integration('has a non-string "description" field', () {
+      var pkg = packageMap("test_pkg", "1.0.0");
+      pkg["description"] = 12;
+      d.dir(appPath, [d.pubspec(pkg)]).create();
+
+      expectValidationError(pubspecField);
+    });
+
+    integration('has a non-string "author" field', () {
+      var pkg = packageMap("test_pkg", "1.0.0");
+      pkg["author"] = 12;
+      d.dir(appPath, [d.pubspec(pkg)]).create();
+
+      expectValidationError(pubspecField);
+    });
+
+    integration('has a non-list "authors" field', () {
+      var pkg = packageMap("test_pkg", "1.0.0");
+      pkg["authors"] = 12;
+      d.dir(appPath, [d.pubspec(pkg)]).create();
+
+      expectValidationError(pubspecField);
+    });
+
+    integration('has a non-string member of the "authors" field', () {
+      var pkg = packageMap("test_pkg", "1.0.0");
+      pkg["authors"] = [12];
+      d.dir(appPath, [d.pubspec(pkg)]).create();
+
+      expectValidationError(pubspecField);
+    });
+
     integration('has a single author without an email', () {
       var pkg = packageMap("test_pkg", "1.0.0");
       pkg["author"] = "Nathan Weizenbaum";
       d.dir(appPath, [d.pubspec(pkg)]).create();
 
       expectValidationWarning(pubspecField);
     });
 
     integration('has one of several authors without an email', () {
       var pkg = packageMap("test_pkg", "1.0.0");
@@ skipping 21 matching lines @@
       pkg.remove("author");
       pkg["authors"] = [
         "Bob Nystrom <rnystrom@google.com>",
         "<nweiz@google.com>",
         "John Messerly <jmesserly@google.com>"
       ];
       d.dir(appPath, [d.pubspec(pkg)]).create();
 
       expectValidationWarning(pubspecField);
     });
+
+    integration('has a non-HTTP homepage URL', () {
+      var pkg = packageMap("test_pkg", "1.0.0");
+      pkg["homepage"] = "file:///foo/bar";
+      d.dir(appPath, [d.pubspec(pkg)]).create();
+
+      expectValidationError(pubspecField);
+    });
+
+    integration('has a non-HTTP documentation URL', () {
+      var pkg = packageMap("test_pkg", "1.0.0");
+      pkg["documentation"] = "file:///foo/bar";
+      d.dir(appPath, [d.pubspec(pkg)]).create();
+
+      expectValidationError(pubspecField);
+    });
   });
 }