Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2424563002: Replace FOR_EACH_OBSERVER in c/b/ui/app_list with range-based for (Closed)

Created:
4 years, 2 months ago by Yusuke Sato
Modified:
4 years, 2 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, tfarina, Matt Giuca
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace FOR_EACH_OBSERVER in c/b/ui/app_list with range-based for BUG=655021 TEST=try, git grep FOR_EACH_OBSERVER c/b/ui/app_list Committed: https://crrev.com/eb6c5349cf9dc4b3a37c8c050e0fa6fa929e1f19 Cr-Commit-Position: refs/heads/master@{#425708}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M chrome/browser/ui/app_list/app_list_syncable_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/start_page_service.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile_store.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Yusuke Sato
PTAL. This was done with: cd c/b/ui/app_list && perl -0777 -pi -e 's/FOR_EACH_OBSERVER\(\s*([\w:]+?)\s*,\s*([\w:()]+?)\s*,\s*([^;]+?)\);/for (auto& observer ...
4 years, 2 months ago (2016-10-17 16:28:58 UTC) #6
xiyuan
lgtm
4 years, 2 months ago (2016-10-17 16:36:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424563002/1
4 years, 2 months ago (2016-10-17 16:56:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 17:20:58 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 17:23:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb6c5349cf9dc4b3a37c8c050e0fa6fa929e1f19
Cr-Commit-Position: refs/heads/master@{#425708}

Powered by Google App Engine
This is Rietveld 408576698