Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2424533003: Revert "Update CPDF_IndirectObjectHolder APIs for unique objects." (Closed)

Created:
4 years, 2 months ago by Tom Sepez
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert "Update CPDF_IndirectObjectHolder APIs for unique objects." This reverts commit 3ba098595ae56b64eacc0c25ab76b89a4d78d920. TBR=thestig@chromium.org,weili@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/c25a4219431c90a95233a08f25eecc921abbf3ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -222 lines) Patch
M core/fpdfapi/edit/cpdf_pagecontentgenerator.cpp View 4 chunks +12 lines, -10 lines 0 comments Download
M core/fpdfapi/edit/fpdf_edit_create.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M core/fpdfapi/page/cpdf_docpagedata.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/page/cpdf_image.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M core/fpdfapi/parser/cfdf_document.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/parser/cpdf_array.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_array.cpp View 2 chunks +2 lines, -8 lines 0 comments Download
M core/fpdfapi/parser/cpdf_array_unittest.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M core/fpdfapi/parser/cpdf_data_avail.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M core/fpdfapi/parser/cpdf_dictionary.h View 1 chunk +0 lines, -3 lines 0 comments Download
M core/fpdfapi/parser/cpdf_dictionary.cpp View 2 chunks +2 lines, -8 lines 0 comments Download
M core/fpdfapi/parser/cpdf_document.cpp View 13 chunks +23 lines, -27 lines 0 comments Download
M core/fpdfapi/parser/cpdf_indirect_object_holder.h View 3 chunks +5 lines, -23 lines 0 comments Download
M core/fpdfapi/parser/cpdf_indirect_object_holder.cpp View 2 chunks +12 lines, -39 lines 0 comments Download
M core/fpdfapi/parser/cpdf_object_unittest.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M core/fpdfapi/parser/cpdf_parser.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M core/fpdfdoc/cpdf_formfield_unittest.cpp View 2 chunks +8 lines, -5 lines 0 comments Download
M core/fpdfdoc/cpdf_interform.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M core/fpdfdoc/cpvt_fontmap.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M core/fpdfdoc/cpvt_generateap.cpp View 7 chunks +14 lines, -11 lines 0 comments Download
M fpdfsdk/cpdfsdk_baannot.cpp View 2 chunks +5 lines, -6 lines 0 comments Download
M fpdfsdk/cpdfsdk_widget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cba_fontmap.cpp View 2 chunks +8 lines, -5 lines 0 comments Download
M fpdfsdk/fpdf_flatten.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M fpdfsdk/fpdf_transformpage.cpp View 4 chunks +17 lines, -12 lines 0 comments Download
M fpdfsdk/fpdfdoc_unittest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfppo.cpp View 4 chunks +8 lines, -9 lines 0 comments Download
M fpdfsdk/fpdfsave.cpp View 2 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
Tom Sepez
4 years, 2 months ago (2016-10-15 00:45:22 UTC) #3
Tom Sepez
4 years, 2 months ago (2016-10-15 00:46:02 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c25a4219431c90a95233a08f25eecc921abbf3ed (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698