Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 242453003: Linux: Remove some ChromeOS linker flag workarounds now that full ChromeOS builds set the flags exp… (Closed)

Created:
6 years, 8 months ago by Lei Zhang
Modified:
6 years, 7 months ago
Reviewers:
vapier
CC:
chromium-reviews
Visibility:
Public.

Description

Linux: Remove some ChromeOS linker flag workarounds now that full ChromeOS builds set the flags explicitly. BUG=360082 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266970

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M build/common.gypi View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Lei Zhang
https://codereview.chromium.org/242453003/diff/1/build/common.gypi File build/common.gypi (left): https://codereview.chromium.org/242453003/diff/1/build/common.gypi#oldcode753 build/common.gypi:753: # it failed on a buildbot. The .ebuild controls ...
6 years, 8 months ago (2014-04-18 06:42:40 UTC) #1
vapier
lgtm
6 years, 8 months ago (2014-04-18 20:14:06 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 8 months ago (2014-04-18 20:38:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/242453003/1
6 years, 8 months ago (2014-04-18 20:38:54 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-18 20:38:55 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-18 20:38:55 UTC) #6
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-04-29 08:15:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/242453003/20001
6 years, 7 months ago (2014-04-29 08:16:03 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 08:56:24 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-29 08:56:24 UTC) #10
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-04-29 17:28:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/242453003/20001
6 years, 7 months ago (2014-04-29 17:29:43 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 22:01:54 UTC) #13
Message was sent while issue was closed.
Change committed as 266970

Powered by Google App Engine
This is Rietveld 408576698