Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 242453002: Pull out flow control functionality from ReliableQuicStream into a new (Closed)

Created:
6 years, 8 months ago by ramant (doing other things)
Modified:
6 years, 8 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Robbie Shade, jar (doing other things)
Visibility:
Public.

Description

Pull out flow control functionality from ReliableQuicStream into a new class, QuicFlowController. Without this refactoring, all the accounting of bytes sent/buffered/consumed, comparisons of these with limits to decide if blocked or not, will be duplicated in ReliableQuicStream and QuicConnection. Putting all this in a new class means it's easier to have more comprehensive testing, simplifies ReliableQuicStream, and will make it much easier to add Connection level flow control (work in progress internal change: 63944402). Refactor of QUIC stream flow control. No behavior change, still protected behind FLAGS_enable_quic_stream_flow_control. This flag is currently disabled. Merge internal change: 64733866 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+615 lines, -249 lines) Patch
M net/net.gypi View 3 chunks +5 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_stream.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_crypto_stream.cc View 2 chunks +1 line, -4 lines 0 comments Download
M net/quic/quic_crypto_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_data_stream.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_data_stream.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/quic_data_stream_test.cc View 11 chunks +41 lines, -34 lines 0 comments Download
A net/quic/quic_flow_controller.h View 1 chunk +113 lines, -0 lines 0 comments Download
A net/quic/quic_flow_controller.cc View 1 chunk +183 lines, -0 lines 0 comments Download
A net/quic/quic_flow_controller_test.cc View 1 chunk +101 lines, -0 lines 0 comments Download
M net/quic/quic_headers_stream.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_headers_stream.cc View 2 chunks +1 line, -4 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_session.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M net/quic/quic_session_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_stream_sequencer.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M net/quic/reliable_quic_stream.h View 6 chunks +8 lines, -22 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 7 chunks +30 lines, -102 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 6 chunks +13 lines, -7 lines 0 comments Download
A net/quic/test_tools/quic_flow_controller_peer.h View 1 chunk +42 lines, -0 lines 0 comments Download
A net/quic/test_tools/quic_flow_controller_peer.cc View 1 chunk +61 lines, -0 lines 0 comments Download
M net/quic/test_tools/reliable_quic_stream_peer.h View 1 chunk +0 lines, -11 lines 0 comments Download
M net/quic/test_tools/reliable_quic_stream_peer.cc View 1 chunk +0 lines, -43 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ramant (doing other things)
6 years, 8 months ago (2014-04-18 01:23:35 UTC) #1
ramant (doing other things)
On 2014/04/18 01:23:35, ramant wrote: Hi Ryan, IMO, because flow control is disabled in chromium, ...
6 years, 8 months ago (2014-04-18 02:04:22 UTC) #2
ramant (doing other things)
On 2014/04/18 02:04:22, ramant wrote: > On 2014/04/18 01:23:35, ramant wrote: > > Hi Ryan, ...
6 years, 8 months ago (2014-04-18 02:45:20 UTC) #3
ramant (doing other things)
On 2014/04/18 02:45:20, ramant wrote: > On 2014/04/18 02:04:22, ramant wrote: > > On 2014/04/18 ...
6 years, 8 months ago (2014-04-18 02:46:16 UTC) #4
Ryan Hamilton
6 years, 8 months ago (2014-04-18 03:39:53 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698