Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Issue 24245005: Add EscapableHandleScope to api to fix problems with HandleScope::Close (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Add EscapableHandleScope to api to fix problems with HandleScope::Close R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16965

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -5 lines) Patch
M include/v8.h View 1 5 chunks +35 lines, -5 lines 0 comments Download
M src/api.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dcarney
7 years, 3 months ago (2013-09-24 15:05:38 UTC) #1
dcarney
ptal
7 years, 2 months ago (2013-09-26 07:36:29 UTC) #2
Michael Starzinger
https://codereview.chromium.org/24245005/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/24245005/diff/1/include/v8.h#newcode778 include/v8.h:778: // TODO(dcarney): deprecated - use CloseableHandleScope::Close. nit: s/Closeable/Escapeable/ https://codereview.chromium.org/24245005/diff/1/include/v8.h#newcode796 ...
7 years, 2 months ago (2013-09-26 09:48:10 UTC) #3
dcarney
https://codereview.chromium.org/24245005/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/24245005/diff/1/include/v8.h#newcode778 include/v8.h:778: // TODO(dcarney): deprecated - use CloseableHandleScope::Close. On 2013/09/26 09:48:11, ...
7 years, 2 months ago (2013-09-26 11:01:44 UTC) #4
Michael Starzinger
LGTM.
7 years, 2 months ago (2013-09-26 13:45:42 UTC) #5
dcarney
7 years, 2 months ago (2013-09-26 13:47:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r16965 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698