Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Unified Diff: third_party/WebKit/Source/core/xml/XPathExpressionNode.h

Issue 2424453002: Handle overflow, underflow in XPath substring position, length. (Closed)
Patch Set: Address nit. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/BUILD.gn ('k') | third_party/WebKit/Source/core/xml/XPathFunctions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/xml/XPathExpressionNode.h
diff --git a/third_party/WebKit/Source/core/xml/XPathExpressionNode.h b/third_party/WebKit/Source/core/xml/XPathExpressionNode.h
index 50ce5dc760d539b7f5cf9a99bc6f86efea3a6ffe..acb4dd5b759e99ece0d5ab26de71a77940efba64 100644
--- a/third_party/WebKit/Source/core/xml/XPathExpressionNode.h
+++ b/third_party/WebKit/Source/core/xml/XPathExpressionNode.h
@@ -27,6 +27,7 @@
#ifndef XPathExpressionNode_h
#define XPathExpressionNode_h
+#include "core/CoreExport.h"
#include "core/dom/Node.h"
#include "core/xml/XPathValue.h"
#include "wtf/HashMap.h"
@@ -37,7 +38,7 @@ namespace blink {
namespace XPath {
-struct EvaluationContext {
+struct CORE_EXPORT EvaluationContext {
STACK_ALLOCATED();
public:
@@ -51,13 +52,13 @@ struct EvaluationContext {
bool hadTypeConversionError;
};
-class ParseNode : public GarbageCollectedFinalized<ParseNode> {
+class CORE_EXPORT ParseNode : public GarbageCollectedFinalized<ParseNode> {
public:
virtual ~ParseNode() {}
DEFINE_INLINE_VIRTUAL_TRACE() {}
};
-class Expression : public ParseNode {
+class CORE_EXPORT Expression : public ParseNode {
WTF_MAKE_NONCOPYABLE(Expression);
public:
« no previous file with comments | « third_party/WebKit/Source/core/BUILD.gn ('k') | third_party/WebKit/Source/core/xml/XPathFunctions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698